remove bsdp package

[pmazzini]

New Mac's no longer support PXE booting. This code is no longer being used with DHCPLB. Fixes #116

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a2c8fb) 72.77% compared to head (18c5a71) 73.13%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
+ Coverage   72.77%   73.13%   +0.36%     
==========================================
  Files          91       80      -11     
  Lines        5777     5059     -718     
==========================================
- Hits         4204     3700     -504     
+ Misses       1398     1216     -182     
+ Partials      175      143      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[insomniacslk]

older macs still support it though. @pmazzini what do we lose leaving this as it is?

[pmazzini]

Older Macs have been phased out. I think nobody is making use of this code at the moment.

[insomniacslk]

Older Macs have been phased out. I think nobody is making use of this code at the moment.

Phased out as in they are not sold anymore? If so, I still expect that those devices will be around for years to come

[insomniacslk]

My point being: I expect that this hardware will lie around in the public market for years still, even if DHCPLB doesn't need then anymore. If there is no downside in removing this code, I'd leave it here for external users

[pmazzini]

afaik the hardware is no longer being sold and the software running on it is no longer maintained / supported.

One benefit of cleaning this up is that we will have one less thing to migrate to the new DHCP client. (ref #459 where there was a previous attempt at removing part of this package).

I have't seen users using this code and would rather avoid leaving stale code around. I thought we would benefit from some cleanup but we can leave it if you think somebody may benefit from it.

[insomniacslk]

Sounds good, thanks for the details. Go ahead!