Define type Serializable - #495
Open
hugelgupf wants to merge 6 commits into
Open
Conversation
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 72.88% 72.90% +0.01%
==========================================
Files 90 90
Lines 5728 5728
==========================================
+ Hits 4175 4176 +1
Misses 1381 1381
+ Partials 172 171 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Moves towards avoiding allocating a new buf.NewBigEndianBuffer in every single FromBytes / ToBytes function. Signed-off-by: Chris Koch <chrisko@google.com>
pmazzini
approved these changes
Mar 6, 2023
Owner
|
this looks good to me as well. The conflicts are easy to fix. @hugelgupf can you please update go.{mod,sum} ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward lazy option parsing -- which I'm not 100% sure should be applied everywhere anymore, but at least should be applied to vendor options for ease of use of the library.
Bit of test coverage improvement here, too.