dhcpv6: switch every Option to parse using FromBytes - #491
Merged
Conversation
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Tests that for the correct option code, the correct deserialization is applied. Signed-off-by: Chris Koch <chrisko@google.com>
Codecov ReportBase: 69.46% // Head: 69.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
==========================================
+ Coverage 69.46% 69.55% +0.09%
==========================================
Files 90 90
Lines 5737 5656 -81
==========================================
- Hits 3985 3934 -51
+ Misses 1571 1546 -25
+ Partials 181 176 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hugelgupf
marked this pull request as ready for review
February 20, 2023 03:48
pmazzini
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
type to the
Optioninterface.This is a pre-requisite for doing either #487 or lazy option parsing. I'm experimenting with both, and unhappy with everything I come up with, so for now I want to merge this improvement.