Added osx to continuous integration - #230
Open
insomniacslk wants to merge 1 commit into
Open
Conversation
pmazzini
previously approved these changes
Jan 17, 2019
Owner
Author
|
I will also commit the fix for FreeBSD and OSX in this PR so I won't merge until then |
Collaborator
|
Seems okay, still need those *BSD fixes though :) |
Owner
Author
yeah, we didn't have time to work on it yet :( this PR won't be merged until the darwin build is fixed |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 73.26% 73.57% +0.30%
==========================================
Files 75 75
Lines 3718 3818 +100
==========================================
+ Hits 2724 2809 +85
- Misses 862 875 +13
- Partials 132 134 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
insomniacslk
force-pushed
the
travis_build_macos
branch
from
April 4, 2019 13:46
bd8ef91 to
6846a30
Compare
Signed-off-by: Andrea Barberio <insomniac@slackware.it>
insomniacslk
force-pushed
the
travis_build_macos
branch
from
July 15, 2019 21:50
6846a30 to
dc25849
Compare
Owner
Author
|
rebased |
Collaborator
|
I think BSD was fixed but now we switched to Github CI. Do you want to update this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #229 we need to test on all the OSes we support