Retry API calls on transient connection errors - #215
Merged
Conversation
Long pulls with many file downloads intermittently die with "Connection reset by peer" (requests.exceptions.ConnectionError), which retry_api_call did not catch - it only retried Notion rate-limit and retryable API-response errors. Retry connection errors with linear backoff, up to the same max attempt count. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwuTg4uAA3UCEeiNLqtpdC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two consecutive full article re-pulls of innolitics.github.io died mid-run with
ConnectionError('Connection reset by peer')during S3 file downloads (Client.download_file→_get_url). Those methods are decorated with@retry_api_call, but the wrapper only retries Notion rate-limit / retryable API-response errors — a transient transport-level failure kills the whole export.Now
requests.exceptions.ConnectionErroris retried with linear backoff (2s, 4s, 6s, 8s) up to the samemax_api_retries. Two unit tests added (retry-then-succeed, and exhaustion re-raises).🤖 Generated with Claude Code
https://claude.ai/code/session_01EwuTg4uAA3UCEeiNLqtpdC