Guard internallinks against blocks without a page - #214
Merged
Conversation
Rich text arrays can be wrapped in contexts whose block has no page (e.g. property values), crashing the plugin on block.page.notion_id and killing the whole export. Defer to the next class instead; only same-page links inside a page's block tree are resolvable anyway. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EwuTg4uAA3UCEeiNLqtpdC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third internallinks hardening fix, hit during a full re-export of innolitics.github.io articles (crashed mid-run at article ~127): rich text arrays can be wrapped for blocks that have no
page(e.g. property-value contexts), and the plugin's constructor guard only checkedblock is Nonebefore dereferencingblock.page.notion_id. Now defers viaUseNextClass— only same-page links inside a page's block tree are resolvable anyway. Regression test included.🤖 Generated with Claude Code
https://claude.ai/code/session_01EwuTg4uAA3UCEeiNLqtpdC