Rs/icore tweaks - #2
Draft
ReeceStevens wants to merge 28 commits into
Draft
Conversation
This matches the equivalency logic of CTP's filter statements. By implementing this, we can directly use common public filters such as the stanford filter.
The previous implementation of the `@integer()` recipe function was hashing the pre-existing tag value (in this case, `SeriesNumber`). In the case where a series number was accidentally wiped by an overly-aggressive deid process, series numbers would start colliding, causing issues viewing the data. `@integer()` was extended to support referencing an arbitrary other tag as the hash input, so now `SeriesNumber` is based on a hash of the `SeriesInstanceUID`, which is more stable and guaranteed to be correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.