fix(connect): harden websocket reconnect and reply delivery - #356
Closed
darwin67 wants to merge 3 commits into
Closed
fix(connect): harden websocket reconnect and reply delivery#356darwin67 wants to merge 3 commits into
darwin67 wants to merge 3 commits into
Conversation
darwin67
marked this pull request as ready for review
May 8, 2026 21:07
mar-inngest
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WORKER_REQUEST_ACKcannot be sent, letting the gateway retry instead of creating a synthetic SDK execution failure/v0/connect/flushattempts so the fallback delivery path can retryReview structure
d61a238guards stale websocket send failures and addssafe_sendcoverage3108435hardens request ACK and flush handling with execution-handler coverageVerification
uv run --extra dev pytest -q pkg/inngest/inngest/connect/_internaluv run ruff checkon touched filesuv run ruff format --checkon touched filescd pkg/inngest && uv run mypy --config-file=../../mypy.ini .