Skip to content

fix(connect): harden websocket reconnect and reply delivery - #356

Closed
darwin67 wants to merge 3 commits into
mainfrom
darwin/SYS-856
Closed

fix(connect): harden websocket reconnect and reply delivery#356
darwin67 wants to merge 3 commits into
mainfrom
darwin/SYS-856

Conversation

@darwin67

@darwin67 darwin67 commented May 8, 2026

Copy link
Copy Markdown

Summary

  • guard Connect websocket send failures so stale sockets can trigger reconnect without clearing a replacement connection
  • abandon executor requests when WORKER_REQUEST_ACK cannot be sent, letting the gateway retry instead of creating a synthetic SDK execution failure
  • keep buffered replies after failed /v0/connect/flush attempts so the fallback delivery path can retry

Review structure

  • d61a238 guards stale websocket send failures and adds safe_send coverage
  • 3108435 hardens request ACK and flush handling with execution-handler coverage

Verification

  • uv run --extra dev pytest -q pkg/inngest/inngest/connect/_internal
  • uv run ruff check on touched files
  • uv run ruff format --check on touched files
  • cd pkg/inngest && uv run mypy --config-file=../../mypy.ini .

@linear-code

linear-code Bot commented May 8, 2026

Copy link
Copy Markdown

SYS-856

@darwin67 darwin67 changed the title SYS-856: wip fix(connect): harden websocket reconnect and reply delivery May 8, 2026
@darwin67
darwin67 marked this pull request as ready for review May 8, 2026 21:07
@darwin67 darwin67 closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants