Skip to content

fix(middleware-sentry): remove unused @sentry/types and bound @sentry/core peer - #1710

Draft
sidsri14 wants to merge 2 commits into
inngest:mainfrom
sidsri14:fix/middleware-sentry-peers
Draft

sidsri14 wants to merge 2 commits into
inngest:mainfrom
sidsri14:fix/middleware-sentry-peers

Conversation

@sidsri14

Copy link
Copy Markdown

Summary

Addresses #1675 by cleaning up Sentry dependencies in @inngest/middleware-sentry:

  1. Drop @sentry/types:
    • @sentry/types is deprecated upstream (all types were unified into @sentry/core).
    • The shipped runtime in dist/ never imported @sentry/types.
    • Replaced internal type references with @sentry/core / ReturnType<typeof Sentry.startInactiveSpan>, and removed @sentry/types from peerDependencies, devDependencies, and vitest dedupe.
  2. Add upper bound to @sentry/core peer dependency:
    • Set @sentry/core peer range to >=8.0.0 <11.0.0, mirroring the bounded pattern used for inngest (>=4.0.0-alpha.6 <5.0.0). This prevents package managers like pnpm from silently resolving to untested future major versions (v11+).
  3. Exclude test helpers from emitted dist/:
    • Updated tsconfig.json exclude to ["./src/**/*.test.*", "./src/test/**/*"] so integration test helpers are not packaged into dist/test/** in the npm tarball.
  4. Added changeset:
    • Added patch changeset for @inngest/middleware-sentry.

Checklist

  • Added a docs PR that references this PR N/A Internal peer dep alignment
  • Added unit/integration tests
  • Added changesets if applicable

Related

AI Disclosure

This PR was prepared with AI assistance following repository contribution rules, with human validation of TypeScript build outputs and dependency configurations.

…/core peer

- Remove deprecated and unused @sentry/types from devDependencies and peerDependencies
- Add upper bound to @sentry/core peerDependency (>=8.0.0 <11.0.0) mirroring inngest peer constraint
- Define Span type in middleware.ts from ReturnType<typeof Sentry.startInactiveSpan>
- Exclude test helpers from tsconfig build output to avoid shipping dist/test

Closes inngest#1675
@changeset-bot

changeset-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f9fe941

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@inngest/middleware-sentry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant