Conversation
…/core peer - Remove deprecated and unused @sentry/types from devDependencies and peerDependencies - Add upper bound to @sentry/core peerDependency (>=8.0.0 <11.0.0) mirroring inngest peer constraint - Define Span type in middleware.ts from ReturnType<typeof Sentry.startInactiveSpan> - Exclude test helpers from tsconfig build output to avoid shipping dist/test Closes inngest#1675
🦋 Changeset detectedLatest commit: f9fe941 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1675 by cleaning up Sentry dependencies in
@inngest/middleware-sentry:@sentry/types:@sentry/typesis deprecated upstream (all types were unified into@sentry/core).dist/never imported@sentry/types.@sentry/core/ReturnType<typeof Sentry.startInactiveSpan>, and removed@sentry/typesfrompeerDependencies,devDependencies, and vitest dedupe.@sentry/corepeer dependency:@sentry/corepeer range to>=8.0.0 <11.0.0, mirroring the bounded pattern used forinngest(>=4.0.0-alpha.6 <5.0.0). This prevents package managers like pnpm from silently resolving to untested future major versions (v11+).dist/:tsconfig.jsonexcludeto["./src/**/*.test.*", "./src/test/**/*"]so integration test helpers are not packaged intodist/test/**in the npm tarball.@inngest/middleware-sentry.Checklist
Added a docs PR that references this PRN/A Internal peer dep alignmentRelated
@sentry/typespeer is unused and deprecated;@sentry/corepeer has no upper bound #1675AI Disclosure
This PR was prepared with AI assistance following repository contribution rules, with human validation of TypeScript build outputs and dependency configurations.