Pin inngest-cli version and cache the binary to avoid postinstall download - #1575
Open
mendral-app[bot] wants to merge 2 commits into
Open
Pin inngest-cli version and cache the binary to avoid postinstall download#1575mendral-app[bot] wants to merge 2 commits into
mendral-app[bot] wants to merge 2 commits into
Conversation
…all failures - Pin inngest-cli to v1.27.0 instead of @latest to ensure deterministic behavior - Add actions/cache step for ~/.npm/_npx to persist the CLI binary across runs - Pre-download inngest-cli before running integration tests - Add retry logic in startDevServer() for cases where postinstall is killed
|
…ry jobs The itest job uses @inngest/test-harness which also spawns inngest-cli@latest. Pin it to 1.27.0 and add cache+pre-download steps for all jobs that use the CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inngest-clito v1.27.0 (instead of@latest) and cache the npx binary directory to eliminate flaky CI failures caused by SIGTERM killing the postinstall download under resource pressurestartDevServer()so if the first attempt fails (download killed), the cached binary is used on the second attemptProblem
The
Test examples (framework-elysiajs)job intermittently fails (~15-30%) becausenpx inngest-cli@latest devtriggers apostinstall.jsthat downloads the CLI binary. Under CI runner resource contention, this download gets SIGTERM'd, preventing the dev server from starting within the 60s timeout.Changes
packages/inngest/scripts/integrationTestRunner.ts: Pininngest-cli@1.27.0, extract CLI args, add retry logic for dev server startup.github/workflows/pr.yml: Addactions/cachefor~/.npm/_npxand a pre-download step before integration tests runRelated insight: https://app.mendral.com/insights/01KTM90WWG0T68V5KVDM37R7KB
Note
Created by Mendral. Tag @mendral-app with feedback or questions.