Add Let's Encrypt configuration and update ingress settings in values.yaml - #2
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive HTTPS support with Let's Encrypt for Kubernetes ingress configurations. It provides automatic SSL certificate provisioning through cert-manager integration with detailed setup instructions and troubleshooting guidance.
- Updated ingress configuration in values.yaml to include Let's Encrypt annotations and TLS settings
- Added ClusterIssuer templates for both production and staging Let's Encrypt environments
- Enhanced README.md with complete HTTPS setup documentation, including prerequisites, installation steps, and troubleshooting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| values.yaml | Updated ingress configuration with nginx class, Let's Encrypt annotations, and TLS certificate settings |
| letsencrypt-clusterissuer.yaml | Added new ClusterIssuer templates for production and staging Let's Encrypt certificate provisioning |
| README.md | Enhanced documentation with comprehensive HTTPS setup guide, cert-manager installation, and troubleshooting section |
| name: letsencrypt-staging | ||
| spec: | ||
| acme: | ||
| server: https://acme-v02.api.letsencrypt.org/directory |
There was a problem hiding this comment.
The staging ClusterIssuer is using the production ACME server URL. It should use the staging URL 'https://acme-staging-v02.api.letsencrypt.org/directory' to avoid production rate limits during testing.
Suggested change
| server: https://acme-v02.api.letsencrypt.org/directory | |
| server: https://acme-staging-v02.api.letsencrypt.org/directory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive updates to enable HTTPS with Let's Encrypt for Kubernetes ingress configurations. The changes include detailed instructions, new YAML templates, and updates to configuration files to streamline automatic SSL certificate provisioning.
Documentation Enhancements:
README.md: Added a new section on setting up HTTPS with Let's Encrypt, including prerequisites, installation steps forcert-manager, and troubleshooting SSL certificates.cert-manager.io/cluster-issuerannotation description to emphasize its requirement for automatic Let's Encrypt certificates.Configuration Updates:
values.yaml: Modified ingress configuration to include annotations for Let's Encrypt, specify the ingress class (nginx), and define TLS settings with a secret name for certificates.New YAML Templates:
letsencrypt-clusterissuer.yaml: Provided templates for both production (letsencrypt-prod) and staging (letsencrypt-staging) ClusterIssuers to facilitate SSL certificate provisioning.