Implement Kubernetes recommended labels for all chart components - #17
Merged
Merged
Conversation
djfarrelly
marked this pull request as ready for review
February 18, 2026 01:23
# Conflicts: # templates/deployment.yaml
djfarrelly
commented
Feb 18, 2026
| # Route traffic to pods with matching labels | ||
| selector: | ||
| {{- include "inngest.selectorLabels" . | nindent 4 }} | ||
| {{- include "inngest.server.selectorLabels" . | nindent 4 }} |
Contributor
Author
There was a problem hiding this comment.
Ensure that traffic is routed to only the server pods, not any other pod like Redis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.kubernetes.io/nameto identify actual applications, not the chart nameDescription
This PR updates the Helm chart to follow Kubernetes recommended labels conventions,
ensuring proper semantic labeling across all components.
Changes
Label Schema:
app.kubernetes.io/nameapp.kubernetes.io/componentapp.kubernetes.io/part-ofinngestserverinngestpostgresqldatabaseinngestredisqueueinngestNew Helper Functions in
_helpers.tpl:inngest.server.labels/inngest.server.selectorLabelsinngest.postgresql.labels/inngest.postgresql.selectorLabelsinngest.redis.labels/inngest.redis.selectorLabelsFiles Modified: 18 files across all template resources
Why This Matters
Previously, all components used the same
app.kubernetes.io/name: inngestlabel, which:nameshould identify the applicationapp.kubernetes.io/componentadditions that were inconsistentNow each component has proper labels that enable:
app.kubernetes.io/name=postgresqlapp.kubernetes.io/part-of=inngestapp.kubernetes.io/component=databaseThis is a breaking change for existing deployments.
Changing
app.kubernetes.io/namein selector labels causes Kubernetes to reject updates to existing Deployments because selector fields are immutable after creation.Upgrade Path:
Users upgrading from previous versions must delete and recreate their deployments: