Extra containers and extra initContainers - #15
Open
ivank wants to merge 1 commit into
Open
Conversation
Add extra containers helm chart so that we can deploy on GCP with Managed SQL instance. That's because GCP wants you to use an sql-auth-proxy
djfarrelly
reviewed
Feb 16, 2026
djfarrelly
left a comment
Contributor
There was a problem hiding this comment.
Hi @ivank - thanks for this PR - I like the idea and would definitely like to support it. One key question that I had with this PR was why the string literal approach instead of yaml configuration for these? I would imagine that configuring these in yaml would be easier as it's structured and easier for other tools to parse, but I may be missing some context in the ecosystem why a yaml-in-string-literal approach is better.
I drafted the yaml approach on top of your work below, but would like your thoughts on this if there are any pros/cons that I may be missing?
Thanks again for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our setup is on GCP and we are using google SQL for postgres. The recommended way to connect to the database is with google's sql auth proxy.
And the easiest way of doing this is to have the proxy running as a sidecar container.
To do that we define
extraContainersandextraInitContainers, and make this consistent in all the deployments so future considerations can also be handled with this - for example a telemetry collector or a logs file reader.I have seen this pattern in a lot of software, for example HashiCorp's consul.
I've already made the same change in another software we are using and that worked out well featbit/featbit-charts#57