test(open-knowledge): stabilize two contention-induced e2e flakes#200
Merged
Conversation
…953)
Two Playwright stress flakes the e2e-stability detector caught under
full-suite contention, with distinct root causes. Both are test-side
fixes with no app behavior change.
crdt-stress.e2e.ts S6: the wait for the user-typed marker to reach
Y.Text('source') via server Observer A used a 10s budget, while the
sibling content-propagation wait just above it uses 30s for the same
Observer-A-mediated convergence. The test runs three turns that each
append the large fixture, so the doc grows to roughly 3x and the later
turns re-derive Y.Text from a much larger fragment; under contention the
marker round-trip then exceeds 10s (measured at 11.4s under a workers=12
over-subscription) while landing well under 30s. The marker is never
dropped (the test's final assertion confirms all three survive), so this
aligns the budget with the sibling wait.
editor-tabs.e2e.ts (sidebar click replaces the active .mdx tab with a
duplicate): the test drove the New-tab button and sidebar treeitems
without the waitForActiveProviderSynced settle barrier that the other
sidebar-driving specs use. Under contention a click can race the
@pierre/trees virtualized tree's first layout and click/focus handling
and hang to the 120s test timeout. This adds settle barriers after the
goto and after the intervening navigation, before the fragile clicks.
Verified green under a workers=12 over-subscription (both targets x3,
crdt markers landing within 30s when they exceed 10s, the new barriers
resolving without hanging) and under the detector invocation.
GitOrigin-RevId: 255f2dddd5a70e1be7019a92b0fb03cc25784634
Contributor
There was a problem hiding this comment.
Automated approval from agents-private public-mirror-sync (run: https://github.com/inkeep/agents-private/actions/runs/27758077455). Source of truth is the monorepo; direct edits on inkeep/open-knowledge are overwritten on next sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.