feat: integrate journal chain into node#146
Open
Fraser999 wants to merge 1 commit into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Fraser999
changed the title
Fraser999
force-pushed
the
fraser/eng-2015/add-journal-chain
branch
2 times, most recently
from
dba28ba to
6da1ac1
Compare
This was referenced May 26, 2026
Fraser999
force-pushed
the
fraser/eng-2015/add-journal-chain
branch
from
6da1ac1 to
52a4458
Compare
Fraser999
force-pushed
the
fraser/eng-2015/add-journal-chain
branch
from
52a4458 to
627967d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires
signet-journal-chainintoSignetNode: every committed block is encoded as aJournal::V1, pushed into a store-less chain task, and streamed out over the new/journalWebSocket.Summary
JournalConfiginsignet-node-config(env-var configurable; defaults 64 MiB / 200 entries / 100-journal subscriber lag).SignetNodeowns the chain handle, a boundedmpscsender, and an in-memory rollingprevious_journal_hash. Main loop usestokio::select!to observe the chain ingestion task alongside host notifications.signet-rpcserving layer takes anOption<JournalChainHandle>. When set, HTTP and WS transports mergejournal_routerand shut down via a sharedCancellationTokenwith a 5s watchdog.Follow-up (ENG-2017)
previous_journal_hashis in-memory only - not persisted, not rewound on revert. First journal after any restart or host revert is rejected by the chain. Ten reorg tests are#[ignore]d until this is fixed.