Repository navigation
feat(ui): show a full client on the client list as soon as it fills up - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The client list shows a client as full as soon as an allocation is placed on it, or as free as soon as one stops. It followed the clients alone, and Nomad streams a change of a client, not of the allocations placed on it, so a full client showed on the next node event or the 30 s poll.
Found and left for later: the screen of one client already asks for Allocation and Node in every namespace and has the same refusal with a token scoped to some namespaces (#186).
Closes #169
Checklist
make checkis greenfeat(ui): ...,fix(nomad): ...