Skip to content

chore: lint with the latest golangci-lint - #178

Merged
ingvarch merged 1 commit into
mainfrom
chore/lint-latest
Nov 4, 2026
Merged

ingvarch merged 1 commit into
mainfrom
chore/lint-latest

Conversation

@ingvarch

@ingvarch ingvarch commented Nov 4, 2026

Copy link
Copy Markdown
Owner

What changes

CI lints with the latest golangci-lint release instead of a pinned one, and make lint lints with whatever golangci-lint is installed. A pinned version fell behind the one a package manager installs, and make check stopped on the version check.

  • make lint still fails when golangci-lint is not installed, and says CI lints with the latest release.
  • The test on the Makefile now checks that CI asks for latest and that any installed version lints.
  • golangci-lint 2.15 brings errcheck 1.30, which reports an error taken from a channel and dropped. The shell test now checks that the wait for a key ended because it was canceled. The read of where a log ends names the error it drops and says why: the stream opened next reads the same log and shows the error.
  • CONTRIBUTING.md and CLAUDE.md say this.

A new golangci-lint release can now fail CI on a branch that did not change. That is the cost of always linting with the latest one.

Checklist

  • The test for this change was written first and failed
  • make check is green
  • The title is a conventional commit: feat(ui): ..., fix(nomad): ...

CI lints with the latest release and make lint takes the installed one, so a new release no longer stops make check. errcheck now reports an error taken from a channel and dropped: the shell test checks why the wait for a key ended, and the read of where a log ends names the error it drops.
@ingvarch ingvarch added this to the v0.17.0 milestone Nov 4, 2026
@ingvarch ingvarch added chore Lint, tooling, CI and upkeep test Tests only labels Nov 4, 2026
@ingvarch
ingvarch merged commit 3c353da into main Nov 4, 2026
5 checks passed
@ingvarch
ingvarch deleted the chore/lint-latest branch November 4, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Lint, tooling, CI and upkeep test Tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant