Allow optional usage of propertiesFile in DatabaseConnectionConfig.#3905
Merged
Conversation
awildturtok
force-pushed
the
feature/expose-hikari-config
branch
from
d0b1ef2 to
787c31e
Compare
thoniTUB
requested changes
Jun 10, 2026
Comment on lines
76
to
78
| hikariConfig.setJdbcUrl(getJdbcConnectionUrl()); | ||
| hikariConfig.setUsername(getDatabaseUsername()); | ||
| hikariConfig.setPassword(getDatabasePassword()); |
Collaborator
There was a problem hiding this comment.
Das kann Werte aus dem PropertiesFile wieder nullen.
Kannst du die HirakiConfig nicht per Mixin deserialisieren?
Collaborator
Author
There was a problem hiding this comment.
Das kann Werte aus dem PropertiesFile wieder nullen.
Oh danke für den Hinweis.
Kannst du die HirakiConfig nicht per Mixin deserialisieren?
Das hatte ich als erstes probiert, aber das soll man explizit nicht machen. die schlagen vor, dass man ein DAO für die spezifics die man mappen will erstellt. Aber ich will ja genau das gegenteil erreichen.
Collaborator
Author
There was a problem hiding this comment.
Also es hat dann auch direkt geknallt
awildturtok
force-pushed
the
feature/expose-hikari-config
branch
from
787c31e to
26e4cde
Compare
awildturtok
force-pushed
the
feature/expose-hikari-config
branch
from
26e4cde to
02606b5
Compare
awildturtok
force-pushed
the
feature/expose-hikari-config
branch
from
02606b5 to
1c3bd44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.