Skip to content

[*] Refactoring - #645

Closed
IAmNotHanni wants to merge 1 commit into
mainfrom
hanni/cleanup
Closed

[*] Refactoring#645
IAmNotHanni wants to merge 1 commit into
mainfrom
hanni/cleanup

Conversation

@IAmNotHanni

Copy link
Copy Markdown
Member

Another day another refactoring.

@IAmNotHanni IAmNotHanni self-assigned this Jan 4, 2026
@IAmNotHanni IAmNotHanni added the cat:refactor refactor/clean up/simplifications/etc. label Jan 4, 2026
@IAmNotHanni IAmNotHanni changed the title [*] Use RAII wrapper for VkSampler [*] Refactoring Jan 4, 2026
@IceflowRE

IceflowRE commented Feb 16, 2026

Copy link
Copy Markdown
Member

The includes should be correctly ordered:

In dir/foo.cc or dir/foo_test.cc, whose main purpose is to implement or test the stuff in dir2/foo2.h, order your includes as follows:

    dir2/foo2.h.
    A blank line
    C system headers, and any other headers in angle brackets with the .h extension, e.g., <unistd.h>, <stdlib.h>, <Python.h>.
    A blank line
    C++ standard library headers (without file extension), e.g., <algorithm>, <cstddef>.
    A blank line
    Other libraries' .h files.
    A blank line
    Your project's .h files.

From Google C++ guidelines.

The code currently is not following any order completely.

@IAmNotHanni

Copy link
Copy Markdown
Member Author

I will close this since we will merge rendergraph2 in the other PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:refactor refactor/clean up/simplifications/etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants