Skip to content

[BF/IM] Allow reseller uplink ports to be updated - #930

Merged
barryo merged 1 commit into
inex:masterfrom
listerr:reseller-pi-fix
Aug 15, 2025
Merged

[BF/IM] Allow reseller uplink ports to be updated#930
barryo merged 1 commit into
inex:masterfrom
listerr:reseller-pi-fix

Conversation

@listerr

@listerr listerr commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

This PR fixes a bug/limitation which meant it was not possible to update physical interfaces of type "Reseller" (reseller uplink ports) without first having to change them back to "Peering" via Switches -> Switch Ports -> (Edit), then make the changes, then set it back to type "Reseller" in Switches -> Switch Ports -> (Edit).

It will also set a new port being added to a VirtualInterface to "Reseller" if existing port in VI is already set to "Reseller".

In addition to the above, I have:

  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

@barryo
barryo merged commit b6c46aa into inex:master Aug 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants