CI + vagrant DB: use data only dumps instead of full schemas - #1076
Open
afk11 wants to merge 1 commit into
Open
CI + vagrant DB: use data only dumps instead of full schemas #1076afk11 wants to merge 1 commit into
afk11 wants to merge 1 commit into
Conversation
…grations to provide structure. Update github workflow and vagrant bootstrap.sh. Providing a full schema dump for CI and vagrant is still supported.
Member
|
Thanks @afk11 - makes sense. I wonder can we improve on the CI element with database seeders so we can reset in one command like We could also then build this into the tests via https://laravel.com/framework/docs/database-testing#resetting-the-database-after-each-test
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going back a few years the project maintained full database dumps (ie, data and schema included) for the vagrant developer VM, and the CI test database
As found in #1072 - some differences had cropped up. Mainly it was our CI database that had drifted. the vagrant VM largely matched migrations.
Both the CI and vagrant environments have test data that is relied upon one way or the other. So to make sure the schemas can't drift, this PR replaces day-to-day use of full schemas with migrations and data-only dumps.
That being said, in the vagrant env, we do continue to support providing a .sql full schema dump to boot from as it can aid development. So if a full schema dump is provided, it'll be imported preferentially, and the data-only dump will be ignored.
With this change, I also have a corresponding PR for the developer documentation inex/ixp-manager-docs-md#31