M polonczyk patch 1#103
Open
M-Polonczyk wants to merge 2 commits into
Open
Conversation
Added a print statement to output the JWT secret for debugging purposes.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates the AWSGoat deployment region from us-east-1 to eu-central-1 across Terraform, application code, CI workflows, and documentation. Also adds a .gitignore and a new openapi.json for module-1.
Changes:
- Replace
us-east-1region references witheu-central-1in Terraform, Lambda code, DynamoDB populate script, and GitHub workflows. - Add
.gitignoreand a newmodules/module-1/openapi.jsonAPI specification. - Update documentation (README and attack manual) to reflect the new region.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/module-2/main.tf | Switch provider region and DB AZ to eu-central-1. |
| modules/module-1/main.tf | Switch provider region and subnet AZ to eu-central-1. |
| modules/module-1/resources/lambda/data/lambda_function.py | Region string update; adds a debug print of the JWT secret. |
| modules/module-1/resources/dynamodb/populate-table.py | Update DynamoDB region. |
| modules/module-1/openapi.json | New API Gateway OpenAPI spec referencing eu-central-1 Lambda ARNs. |
| attack-manuals/module-1/07-IAM Privilege Escalation.md | Update example AWS CLI region. |
| README.md | Update pricing region text. |
| .gitignore | Add Terraform/Python ignore patterns. |
| .github/workflows/tf-apply-main.yml | Update workflow AWS_REGION. |
| .github/workflows/tf-destroy-main.yml | Update workflow AWS_REGION. |
Files not reviewed (1)
- modules/module-1/.terraform.lock.hcl: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def generate_auth(userInfo): | ||
| if userInfo is not None: | ||
| JWT_SECRET = os.environ["JWT_SECRET"] | ||
| print(JWT_SECRET) |
Comment on lines
+44
to
45
| location = "eu-central-1" | ||
| object_url = "https://%s.s3.amazonaws.com/%s" % (bucket, object_name) |
| } | ||
| }, | ||
| "x-amazon-apigateway-integration" : { | ||
| "uri" : "arn:aws:apigateway:eu-central-1:lambda:path/2015-03-31/functions/arn:aws:lambda:eu-central-1:140986930558:function:blog-application-data/invocations", |
| # Pricing | ||
|
|
||
| The resources created with the deployment of AWSGoat will not incur any charges if the AWS account is under the free tier/trial period. However, upon exhaustion/ineligibility of the free tier/trial, the following charges will apply for the US-East region: | ||
| The resources created with the deployment of AWSGoat will not incur any charges if the AWS account is under the free tier/trial period. However, upon exhaustion/ineligibility of the free tier/trial, the following charges will apply for the eu-central region: |
| @@ -138,7 +138,7 @@ resource "aws_db_instance" "database-instance" { | |||
| password = "T2kVB3zgeN3YbrKS" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.