Skip to content

Ignore out-of-range Nanit sensor readings before publishing to MQTT #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kalakris wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ignore out-of-range Nanit sensor readings before publishing to MQTT #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions pkg/app/websocket_handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,21 @@ func processSensorData(babyUID string, sensorData []*client.SensorData, stateMan
stateUpdate := baby.State{}
for _, sensorDataSet := range sensorData {
if *sensorDataSet.SensorType == client.SensorType_TEMPERATURE {
stateUpdate.SetTemperatureMilli(*sensorDataSet.ValueMilli)
// Nanit occasionally reports -1000000 (-1000 °C) as an invalid-reading
// sentinel. Ignore physically impossible values (valid room range
// -20..60 °C) so we don't publish garbage to MQTT.
if v := *sensorDataSet.ValueMilli; v > -20000 && v < 60000 {
stateUpdate.SetTemperatureMilli(v)
} else {
log.Warn().Int32("valueMilli", v).Str("babyUID", babyUID).Msg("Ignoring out-of-range temperature reading")
}
}
if *sensorDataSet.SensorType == client.SensorType_HUMIDITY {
stateUpdate.SetHumidityMilli(*sensorDataSet.ValueMilli)
if v := *sensorDataSet.ValueMilli; v >= 0 && v <= 100000 {
stateUpdate.SetHumidityMilli(v)
} else {
log.Warn().Int32("valueMilli", v).Str("babyUID", babyUID).Msg("Ignoring out-of-range humidity reading")
}
}
if *sensorDataSet.SensorType == client.SensorType_NIGHT {
stateUpdate.SetIsNight(*sensorDataSet.Value == 1)
Expand Down