Skip to content

Keys for batch action defaults CROSSLINK-297#667

Open
skomorokh wants to merge 1 commit into
mainfrom
batch-i18n-keys-crosslink-297
Open

Keys for batch action defaults CROSSLINK-297#667
skomorokh wants to merge 1 commit into
mainfrom
batch-i18n-keys-crosslink-297

Conversation

@skomorokh

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 14, 2026 19:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds stable localization keys to the built-in batch action defaults exposed by the patron-request API, so clients can translate titles reliably instead of keying off the human-readable title.

Changes:

  • Add titleKey to each batchActionDefaults entry in misc/state-models.yaml and regenerate the embedded state-models.json.
  • Update the patron-request state model service to return []BatchActionDefault instead of []CreateBatchAction.
  • Extend the OpenAPI spec with a BatchActionDefault schema (CreateBatchAction + required titleKey) and update the batch-actions-defaults endpoint to return that schema; add a test to ensure titleKey is present and unique.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
misc/state-models.yaml Adds titleKey fields for each built-in batch action default.
broker/patron_request/service/statemodels/state-models.json Regenerates embedded defaults to include titleKey.
broker/patron_request/service/statemodel.go Switches config/return types to BatchActionDefault and preserves deep-copy behavior.
broker/patron_request/api/api-handler_test.go Ensures defaults include non-empty, unique titleKey values.
broker/oapi/open-api.yaml Introduces BatchActionDefault schema and updates the defaults endpoint response type.

@skomorokh skomorokh marked this pull request as ready for review July 14, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants