Keys for batch action defaults CROSSLINK-297#667
Open
skomorokh wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds stable localization keys to the built-in batch action defaults exposed by the patron-request API, so clients can translate titles reliably instead of keying off the human-readable title.
Changes:
- Add
titleKeyto eachbatchActionDefaultsentry inmisc/state-models.yamland regenerate the embeddedstate-models.json. - Update the patron-request state model service to return
[]BatchActionDefaultinstead of[]CreateBatchAction. - Extend the OpenAPI spec with a
BatchActionDefaultschema (CreateBatchAction + requiredtitleKey) and update the batch-actions-defaults endpoint to return that schema; add a test to ensuretitleKeyis present and unique.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| misc/state-models.yaml | Adds titleKey fields for each built-in batch action default. |
| broker/patron_request/service/statemodels/state-models.json | Regenerates embedded defaults to include titleKey. |
| broker/patron_request/service/statemodel.go | Switches config/return types to BatchActionDefault and preserves deep-copy behavior. |
| broker/patron_request/api/api-handler_test.go | Ensures defaults include non-empty, unique titleKey values. |
| broker/oapi/open-api.yaml | Introduces BatchActionDefault schema and updates the defaults endpoint response type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.