Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

feat(filter): filter repositories by IGNORE_REPOSITORIES and GITHUB_ORGANIZATIONS - #135

Open
jacksjm wants to merge 2 commits into
indeedeng:mainfrom
jacksjm:feature/filter-repositories
Open

feat(filter): filter repositories by IGNORE_REPOSITORIES and GITHUB_ORGANIZATIONS#135
jacksjm wants to merge 2 commits into
indeedeng:mainfrom
jacksjm:feature/filter-repositories

Conversation

@jacksjm

@jacksjm jacksjm commented Oct 4, 2022

Copy link
Copy Markdown

Fixed Issue #66

@jacksjm

jacksjm commented Oct 4, 2022

Copy link
Copy Markdown
Author

@danisyellis hope to find you well! would that be your need? if yes, could you approve the PR? I'm contributing to the hacktoberfest, if you can tag the PR I'd appreciate it too

@danisyellis

Copy link
Copy Markdown
Contributor

Thanks for your contribution @jacksjm! At a first glance, this looks like it will do what we're looking for. I'll take a more thorough look and do some code review soon.
(And I'll make sure to tag it for Hacktoberfest once it's approved :-)

@jacksjm

jacksjm commented Oct 5, 2022

Copy link
Copy Markdown
Author

Thanks a lot @danisyellis and waiting feedback :D

@danisyellis danisyellis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my code review (finally, I know.)

A lot of it is small naming changes, but there are also some functionality issues that need to be fixed.
I'm going to mark your PR as Hacktoberfest accepted to make sure you get credit since it's my fault the review is coming so late, but I'd still love it if you could make the changes :-)

Let me know if you have any questions about my comments.

Comment thread .env.template Outdated
Comment thread .env.template Outdated
Comment thread globals.js Outdated
Comment thread globals.js Outdated
Comment thread starfish.js Outdated
Comment thread starfish.js Outdated
Comment thread starfish.js Outdated
@danisyellis danisyellis added the hacktoberfest-accepted Thanks for contributing! label Oct 26, 2022
@jacksjm

jacksjm commented Oct 28, 2022

Copy link
Copy Markdown
Author

Here's my code review (finally, I know.)

A lot of it is small naming changes, but there are also some functionality issues that need to be fixed. I'm going to mark your PR as Hacktoberfest accepted to make sure you get credit since it's my fault the review is coming so late, but I'd still love it if you could make the changes :-)

Let me know if you have any questions about my comments.

Off course! I'm very glad to proceed with these fixes... now I'm little busy, but soon I work on this

@jacksjm
jacksjm requested a review from danisyellis October 29, 2022 03:58
@kevindigo

Copy link
Copy Markdown
Contributor

@jacksjm : Thanks for submitting your updates. Dani isn't available to review them right now, but will do so as soon as possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hacktoberfest-accepted Thanks for contributing!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants