don't parse Jsonnet as YAML if it has runtime errors - #192
Open
vinayvinay wants to merge 1 commit into
Open
Conversation
fixes issue reported by @lawrencejones: incident-io#66 (refreshing my memory on Go by doing something useful)
samstarling
reviewed
Jun 30, 2025
samstarling
left a comment
samstarling
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution — this makes sense, but there's an issue with the error handling, as I think we swallow all errors. Currently we use any error as a sign to just carry on and try the rest of the Parse function.
I wonder if we maybe want to introspect the suffix of the filename to try and work out which parser we should use? This would be a breaking change, however.
Comment on lines
+24
to
30
| if jsonString, err := jsonnet.MakeVM().EvaluateSnippet(filename, string(data)); err != nil { | ||
| if strings.HasPrefix(err.Error(), "RUNTIME ERROR") { | ||
| return []Entry{}, err | ||
| } | ||
| } else { | ||
| data = []byte(jsonString) | ||
| } |
Contributor
There was a problem hiding this comment.
It would be a little neater (and more idiomatic) to do something like:
var jsonnetError jsonnet.RuntimeError
if errors.As(err, &jsonnetError) {
// handle error
}
This code also swallows any other errors, and so I think we need to work out an approach for those cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes issue #66 reported by @lawrencejones.
(refreshing my memory on Go by doing something useful)