Skip to content

Add --no-prune-missing-entries flag for sync command - #183

Open
nikita-vanyasin wants to merge 1 commit into
incident-io:masterfrom
nikita-vanyasin:no-prune-missing-entries
Open

Add --no-prune-missing-entries flag for sync command#183
nikita-vanyasin wants to merge 1 commit into
incident-io:masterfrom
nikita-vanyasin:no-prune-missing-entries

Conversation

@nikita-vanyasin

Copy link
Copy Markdown

Closes #182

It is actually vibe-coded. Didn't test yet. Just wanted to let you know I'm working on this

@nikita-vanyasin

Copy link
Copy Markdown
Author

I'm actually quite satisfied with the test runs. I'm going to run it for our env tomorrow.

I'll be happy if you guys can run this branch on some kind of e2e tests if you have them (other than _test.go files in this repo).

Best,
Nikita

@nikita-vanyasin
nikita-vanyasin marked this pull request as ready for review May 8, 2025 14:37
@samstarling

Copy link
Copy Markdown
Contributor

Hey @nikita-vanyasin — thanks for raising this. The philosophy of catalog-importer is that all of the entries for a given type should be managed by the importer: that is, it should be the complete source of truth for all the entries of a given type. For that reason, I don't think we'd want to support an option which allows the removal of missing entries.

I spoke to a couple of folks here and know that you had some trouble with the external IDs of catalog entries (which can't be changed, also by design) and I read through your issue — although we won't merge this, did you manage to achieve what you were trying to achieve?

@nikita-vanyasin

Copy link
Copy Markdown
Author

Hey @nikita-vanyasin — thanks for raising this. The philosophy of catalog-importer is that all of the entries for a given type should be managed by the importer: that is, it should be the complete source of truth for all the entries of a given type. For that reason, I don't think we'd want to support an option which allows the removal of missing entries.

I spoke to a couple of folks here and know that you had some trouble with the external IDs of catalog entries (which can't be changed, also by design) and I read through your issue — although we won't merge this, did you manage to achieve what you were trying to achieve?

Thank you, it makes sense.
I managed to complete my task with changes from this PR. It was a one-off job, so not a big deal anymore.

Best,
Nikita

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] do not remove entries that are not present in source

2 participants