Skip to content

#6209 - Clean up deprecated code in AnnotationDetailEditorPanel - #6210

Merged
reckart merged 1 commit into
mainfrom
refactoring/6209-Clean-up-deprecated-code-in-AnnotationDetailEditorPanel
Aug 3, 2026
Merged

#6209 - Clean up deprecated code in AnnotationDetailEditorPanel#6210
reckart merged 1 commit into
mainfrom
refactoring/6209-Clean-up-deprecated-code-in-AnnotationDetailEditorPanel

Conversation

@reckart

@reckart reckart commented Aug 2, 2026

Copy link
Copy Markdown
Member

What's in the PR

  • Remove deprecated AnnotationFS-based action handler methods (actionSelect, actionSelectAndJump, actionJump, actionCreateOrUpdate) and replace with VID-based equivalents
  • Remove unused Objects import from AnnotationDetailEditorPanel
  • Clean up ActionHandler interface by removing deprecated methods that are superseded by VID-based alternatives
  • Simplify ReadOnlyActionHandler by removing stub implementations of deprecated methods
  • Update AnnotationDetailEditorPanel to use private actionSelectAndJump and consolidate method references to selectAnnotationByAddr and selectFsByAddr

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Remove deprecated AnnotationFS-based action handler methods (actionSelect, actionSelectAndJump, actionJump, actionCreateOrUpdate) and replace with VID-based equivalents
- Remove unused Objects import from AnnotationDetailEditorPanel
- Clean up ActionHandler interface by removing deprecated methods that are superseded by VID-based alternatives
- Simplify ReadOnlyActionHandler by removing stub implementations of deprecated methods
- Update AnnotationDetailEditorPanel to use private actionSelectAndJump and consolidate method references to selectAnnotationByAddr and selectFsByAddr
@reckart reckart added this to the 42.0 milestone Aug 2, 2026
@reckart reckart self-assigned this Aug 2, 2026
@reckart reckart added this to Kanban Aug 2, 2026
@github-project-automation github-project-automation Bot moved this to 🔖 To do in Kanban Aug 2, 2026
@reckart
reckart merged commit 1f0af9a into main Aug 3, 2026
5 of 6 checks passed
@reckart
reckart deleted the refactoring/6209-Clean-up-deprecated-code-in-AnnotationDetailEditorPanel branch August 3, 2026 20:41
@github-project-automation github-project-automation Bot moved this from 🔖 To do to 🍹 Done in Kanban Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🍹 Done

Development

Successfully merging this pull request may close these issues.

1 participant