Skip to content

#2312 - Add support for new external recommender v2 - #2313

Draft
jcklie wants to merge 84 commits into
mainfrom
feature/2312-external-recommender-v2
Draft

#2312 - Add support for new external recommender v2#2313
jcklie wants to merge 84 commits into
mainfrom
feature/2312-external-recommender-v2

Conversation

@jcklie

@jcklie jcklie commented May 30, 2021 •
edited by reckart
Loading

Copy link
Copy Markdown
Contributor

What's in the PR

  • Move old external recommender to v1 subpackage
  • Can check connection to v2 recommender
  • Can select classifiers from the server
  • Predicting works
  • Training works

How to test manually

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@jcklie
#2312 - Add support for new external recommender v2
3dd2894 
- Move old external recommender to v1 subpackage
@jcklie jcklie added this to the 0.21.0 milestone May 30, 2021
@jcklie jcklie self-assigned this May 30, 2021
jcklie added 10 commits May 30, 2021 21:38
@jcklie
#2312 - Add support for new external recommender v2
e893679 
- Add a v2 copy of the v1 external recommender
@jcklie
#2312 - Add support for new external recommender v2
26738d1 
- Fix/Add autoconfig for external recommender
@jcklie
#2312 - Add support for new external recommender v2
5dfdef3 
- Fix/Add autoconfig for external recommender
@jcklie
#2312 - Add support for new external recommender v2
a8bc327 
- Can check connection
@jcklie
#2312 - Add support for new external recommender v2
b2f145c 
- Remove old documents
@jcklie
#2312 - Add support for new external recommender v2
fe09442 
- Can select classifiers from the server
@jcklie
#2312 - Add support for new external recommender v2
2f0085f 
- Move v1 tests to their own sub package
@jcklie
#2312 - Add support for new external recommender v2
dd9f8c8 
- Add FormatConverter
- Add data classes
- Started tests
@jcklie
#2312 - Add support for new external recommender v2
3a0d2cd 
- Start predicting
@jcklie
#2312 - Add support for new external recommender v2
31ee5fa 
- Predicting works
@reckart
reckart marked this pull request as draft June 5, 2021 22:31
jcklie and others added 13 commits June 13, 2021 18:31
@jcklie
Merge branch 'master' into feature/2312-external-recommender-v2
d611fc8
@jcklie
#2312 - Add support for new external recommender v2
eebc383 
Use exceptions in external recommender API
@jcklie
#2312 - Add support for new external recommender v2
ba49d5a 
Use exceptions in external recommender API
@jcklie
#2312 - Add support for new external recommender v2
e741152 
WIP: Add more API methods
@jcklie
Merge branch 'master' into feature/2312-external-recommender-v2
0684d17
@jcklie
#2312 - Add support for new external recommender v2
6863195 
- Add more API implementations
- Add more tests
@jcklie
#2312 - Add support for new external recommender v2
99bc6a8 
- Start implementing training
@jcklie
#2312 - Add support for new external recommender v2
a605e94 
- Add tests for two more API endpoints
- Improved error messages
@jcklie
#2312 - Add support for new external recommender v2
b0754cb 
- Use simpler for classifier/model ids
- Add status code check for listDocumentsInDataset
@reckart
Merge branch 'master' into feature/2312-external-recommender-v2
043b89c
@reckart
Merge branch 'master' into feature/2312-external-recommender-v2
48667c1
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
c2137cf 
* main: (80 commits)
  #2505 - Slot features should be ignored when comparing annotations for the purpose of bulk-annotation
  #2505 - Slot features should be ignored when comparing annotations for the purpose of bulk-annotation
  #2286 - Upgrade dependencies
  #2491 - Bulk-deletion does not unselect annotation
  #2543 Show export progress only on export
  #2541 Cannot export project when curation started
  #2534 Add word conversion colab notebook
  No issue. Fix scope of the tocify dependencies.
  No issue. Fix layout on external search page.
  #2522 - Opening sidebar changes document
  No issue. Avoid error when switching from main to 20.x branch.
  #2176 - Make long relations nicer without arcs II
  Bump elasticsearch from 6.8.15 to 6.8.17 in /inception
  #2534 Add word conversion colab notebook
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-20.1
  #2523 - Reset filter on dynamic workload page
  #2176 - Make long relations nicer without arcs II
  #2522 - Opening sidebar changes document
  #2426 - Difference in labelling of annotation marker vs identifier lookup
  ...
@jcklie
Merge branch 'main' into feature/2312-external-recommender-v2
66cb386
@reckart reckart removed this from the 21.0 milestone Sep 1, 2021
@reckart reckart modified the milestones: 32.0, 33.0 Mar 9, 2024
@reckart reckart modified the milestones: 33.0, 34.0 Jun 2, 2024
@reckart reckart modified the milestones: 34.0, 35.0 Jul 27, 2024
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
208dc92 
* main: (359 commits)
  #5047 - Clean up layer detail UI a bit
  #4949 - Showing the start and end points of relations in left side bar
  No issue: Minor cleaning up
  #5043 - Ability to specify token breaking zones when calling tokenizer
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0-beta-6
  #5009 - Better handling of stacked annotations with link features in curation
  #5009 - Better handling of stacked annotations with link features in curation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0-beta-6
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.6
  #5040 - Improve feature form tab navigation
  #5037 - Show fraction of annotators that chose a certain label in curation sidebar mode
  #5035 - NBSPs should not be treated as tokens
  #5031 - ChatGPT recommender fails because format is not a supported parameter
  #5029 - Duplicate lines on the about page
  #5027 - Add more CSP configurations
  #4753 - Entity linker should skip already linked concepts
  #5007 - Lazy details on suggestions for multi-value concept features fail rendering
  ...
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
168fd5e 
* main: (30 commits)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0
  No issue: Mention MS SQL and PosgreSQL as experimental DB options
  No issue: Fix versions after merge
  #5043 - Ability to specify token breaking zones when calling tokenizer
  #5064 - Project template for PHI annotation
  #5071 - Better document which layers are supported by which formats
  #5061 - Multiple synchronous recommenders only the last one wins
  #5064 - Project template for PHI annotation
  #5068 - Show annotation sidebar by default
  #5033 - Ability to configure recommenders interactively on the annotation page
  #5066 - Increase default number of rows for brat editors
  #5056 - Ability to configure additional languages for knowledge bases
  #4909 - Upgrade dependencies
  #5056 - Ability to configure additional languages for knowledge bases
  #4909 - Upgrade dependencies
  No issue: Actually, document-metadata doesn't seem to be experimental after all...
  No issue: Set version to 35.0-SNAPSHOT
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.7
  ...
@reckart reckart modified the milestones: 35.0, 36.0 Jan 7, 2025
@reckart reckart modified the milestones: 36.0, 37.0 Feb 6, 2025
@reckart reckart modified the milestones: 37.0, 38.0 Jun 10, 2025
reckart added 2 commits June 10, 2025 17:33
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
105bd9c 
* main: (347 commits)
  #5449 - Documents not marked as finished in export despite all annotators being done
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-36.5
  #5395 - Drop plugin API
  #5431 - Allow triggering bulk recommender via remote API
  #5431 - Allow triggering bulk recommender via remote API
  #5431 - Allow triggering bulk recommender via remote API
  #5431 - Allow triggering bulk recommender via remote API
  No issue: Autoformatting
  #5444 - Error when recommender recommender predicts null for multi-value string feature
  #5443 - Intertext plugin renders too slow for large richly annotated documents
  #5431 - Allow triggering bulk recommender via remote API
  #5431 - Allow triggering bulk recommender via remote API
  #5431 - Allow triggering bulk recommender via remote API
  #5431 - Allow triggering bulk recommender via remote API
  #5380 - Upgrade dependencies
  #5439 - Document name not available in document metadata
  #5380 - Upgrade dependencies
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-36.4
  ...
@reckart
#2312 - Add support for new external recommender v2
4b5ceaa 
- Adjust to API changes
@reckart reckart modified the milestones: 38.0, 39.0 Aug 29, 2025
@reckart reckart modified the milestones: 39.0, 40.0 Nov 25, 2025
@reckart reckart modified the milestones: 40.0, 41.0 Feb 3, 2026
reckart added 4 commits May 8, 2026 22:06
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
50bbbd5 
* main: (587 commits)
  #5999 - Upgrade dependencies
  #3614 - Float features round really aggressively
  #1911 - Log out user when revoking roles and indicate when manual re-login is necessary
  #2401 - Per-project log should be removed when project is deleted
  #6014 - Document goes not scroll to last position a feature was updated
  #6012 - Auto-formatting for code
  #6014 - Document goes not scroll to last position a feature was updated
  #6012 - Auto-formatting for code
  #6012 - Auto-formatting for code
  #6012 - Auto-formatting for code
  #3411 - Resize sidebars using mouse
  #6012 - Auto-formatting for code
  #3411 - Resize sidebars using mouse
  #5999 - Upgrade dependencies
  #5113 - Recommendations for multi-value features on document-level annotations broken
  #5113 - Recommendations for multi-value features on document-level annotations broken
  #5114 - Relation suggestions hidden even when stacking is enabled
  #2002 - Better error message when exporting a CAS with dangling relations as TSV
  #5114 - Relation suggestions hidden even when stacking is enabled
  #1084 - Stacking relations in PDF editor
  ...

% Conflicts:
%	inception/inception-imls-external/pom.xml
%	inception/inception-imls-external/src/main/java/de/tudarmstadt/ukp/inception/recommendation/imls/external/v1/ExternalRecommenderFactory.java
%	inception/inception-imls-external/src/main/java/de/tudarmstadt/ukp/inception/recommendation/imls/external/v1/config/ExternalRecommenderAutoConfiguration.java
%	inception/inception-recommendation-api/src/main/java/de/tudarmstadt/ukp/inception/recommendation/api/recommender/PredictionContext.java
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
64d3a72 
* main: (28 commits)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-41.0-beta-1
  No issue: Javadoc fix
  #5982 - Add application bundle for macOS
  No issue: Javadoc fix
  #6028 - Use JSON notation in Dockerfile
  #5972 - Support obfuscated export
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-40.4
  #4121 - Annotations are missing when exporting in NIF
  #6025 - Users can no longer access own profile and change password
  #6023 - Unset password notice sometimes not showing in user detail editor
  #5972 - Support obfuscated export
  #989 - Import annotated texts from PubAnnotation
  #989 - Import annotated texts from PubAnnotation
  #989 - Import annotated texts from PubAnnotation
  #989 - Import annotated texts from PubAnnotation
  #989 - Import annotated texts from PubAnnotation
  #989 - Import annotated texts from PubAnnotation
  #989 - Import annotated texts from PubAnnotation
  ...
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
d04cfa1 
* main: (62 commits)
  Issue #5960: Upgrade dependencies
  Issue #5960: Upgrade dependencies
  Issue #5960: Upgrade dependencies
  Issue #5960: Upgrade dependencies
  #6076 - Display token and sentence count in the open document dialog
  #6076 - Display token and sentence count in the open document dialog
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-41.0-beta-2
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-40.5
  #5960 - Upgrade dependencies
  #5960 - Upgrade dependencies
  #5960 - Upgrade dependencies
  #6071 - Drop LIF module
  #6069 - Improve SPARQL queries against RDF4J
  #6069 - Improve SPARQL queries against RDF4J
  #6069 - Improve SPARQL queries against RDF4J
  #6069 - Improve SPARQL queries against RDF4J
  #6069 - Improve SPARQL queries against RDF4J
  #6069 - Improve SPARQL queries against RDF4J
  ...
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
231e817 
* main:
  #6091 - Document area collapses and scrolling stutters in Safari and Firefox for custom XML formats with namespaced section elements
  #6091 - Document area collapses and scrolling stutters in Safari and Firefox for custom XML formats with namespaced section elements
  #6091 - Document area collapses and scrolling stutters in Safari and Firefox for custom XML formats with namespaced section elements
  #6091 - Document area collapses and scrolling stutters in Safari and Firefox for custom XML formats with namespaced section elements
  #6091 - Document area collapses and scrolling stutters in Safari and Firefox for custom XML formats with namespaced section elements
  #6091 - Document area collapses and scrolling stutters in Safari and Firefox for custom XML formats with namespaced section elements
  #6091 - Document area collapses and scrolling stutters in Safari and Firefox for custom XML formats with namespaced section elements
  #6095 - Auto-login causes an infinite redirect loop under a non-root server.servlet.context-path
  #6095 - Auto-login causes an infinite redirect loop under a non-root server.servlet.context-path
  No issue: Fix building of cross-repo pull requests
  #6087 - Keep data of annotators removed from the project accessible
  #6088 - Hovering an annotation with a link feature fails to show hover details
  #6081 - Manage explorer report configurations
  #6083 - Read document information from CASMetadata if possible
  No issue: Cleaning up whitespace in license headers
  #6079 - Search match highlight remains lock at position when switching between documents
@reckart reckart modified the milestones: 41.0, 42.0 Jun 9, 2026
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
1fb90f4 
* main: (22 commits)
  No issue: Fix error in Eclipse because compile dependency transitively requires slf4j-api
  #6100 - Deleting a recently active project may intermittently fail with an error on MariaDB 11
  #6102 - Outdated system requirements in documentation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-40.6
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6040 - Improve LLM infrastructure
  #6097 - Recommender produces no suggestions in the first project of a new installation
  #6097 - Recommender produces no suggestions in the first project of a new installation
  #6097 - Recommender produces no suggestions in the first project of a new installation
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jcklie jcklie

Labels

⭐️ Enhancement New feature or request Module: Recommender

Projects

None yet

Milestone

42.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jcklie @reckart