Skip to content

Remove output redirection from shell scripts - #24

Merged
kennethmyhra merged 1 commit into
masterfrom
feature/flex-output
Aug 2, 2026
Merged

Remove output redirection from shell scripts#24
kennethmyhra merged 1 commit into
masterfrom
feature/flex-output

Conversation

@losolio

@losolio losolio commented Feb 14, 2026

Copy link
Copy Markdown
Contributor

Output now goes directly to stdout/stderr. Callers can redirect as needed. CI workflow updated to use tee for console output + log file.

BREAKING: logs/*.log files are no longer created automatically. Use ./execute_all.sh ... 2>&1 | tee logs/execute_all.log if needed.

Alternatives to this approach could be to set output depending on env vars, github actions sets CI=true, which could be used as a flag, but this approach gives most flexibility, however the caller must specifiy the output after this.

An alternative approach could be to make separate scripts for console logging?

Copilot AI review requested due to automatic review settings February 14, 2026 13:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes automatic output redirection from the repository’s shell wrappers so that rake task output goes straight to stdout/stderr, and updates CI/documentation to show callers how to capture logs explicitly (e.g., via tee).

Changes:

  • Remove > logs/*.log 2>&1 redirection from list_all.sh, execute_test.sh, and execute_all.sh.
  • Update CI to pipe execute_all.sh output through tee to both console and a log file.
  • Document the new logging approach in README.md, including tee examples.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
list_all.sh Stops redirecting output to logs/list_all.log; output now goes to stdout/stderr.
execute_test.sh Stops redirecting output to logs/execute_$TEST.log; output now goes to stdout/stderr.
execute_all.sh Stops redirecting output to logs/execute_all.log; output now goes to stdout/stderr.
README.md Adds a “Logging Output” section with tee/redirection examples.
.github/workflows/ci.yml Updates CI run step to use tee to capture console output into logs/execute_all.log.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Output now goes directly to stdout/stderr. Callers can redirect as needed.

CI workflow updated to use `tee` for console output + log file.

BREAKING: logs/*.log files are no longer created automatically.
Use `./execute_all.sh ... 2>&1 | tee logs/execute_all.log` if needed.
@kennethmyhra
kennethmyhra merged commit 1541fcb into master Aug 2, 2026
5 checks passed
@kennethmyhra
kennethmyhra deleted the feature/flex-output branch August 2, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants