Remove output redirection from shell scripts - #24
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes automatic output redirection from the repository’s shell wrappers so that rake task output goes straight to stdout/stderr, and updates CI/documentation to show callers how to capture logs explicitly (e.g., via tee).
Changes:
- Remove
> logs/*.log 2>&1redirection fromlist_all.sh,execute_test.sh, andexecute_all.sh. - Update CI to pipe
execute_all.shoutput throughteeto both console and a log file. - Document the new logging approach in
README.md, includingteeexamples.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
list_all.sh |
Stops redirecting output to logs/list_all.log; output now goes to stdout/stderr. |
execute_test.sh |
Stops redirecting output to logs/execute_$TEST.log; output now goes to stdout/stderr. |
execute_all.sh |
Stops redirecting output to logs/execute_all.log; output now goes to stdout/stderr. |
README.md |
Adds a “Logging Output” section with tee/redirection examples. |
.github/workflows/ci.yml |
Updates CI run step to use tee to capture console output into logs/execute_all.log. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Output now goes directly to stdout/stderr. Callers can redirect as needed. CI workflow updated to use `tee` for console output + log file. BREAKING: logs/*.log files are no longer created automatically. Use `./execute_all.sh ... 2>&1 | tee logs/execute_all.log` if needed.
kennethmyhra
force-pushed
the
feature/flex-output
branch
from
August 2, 2026 12:48
a5513fa to
eb41aa7
Compare
kennethmyhra
approved these changes
Aug 2, 2026
kennethmyhra
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output now goes directly to stdout/stderr. Callers can redirect as needed. CI workflow updated to use
teefor console output + log file.BREAKING: logs/*.log files are no longer created automatically. Use
./execute_all.sh ... 2>&1 | tee logs/execute_all.logif needed.Alternatives to this approach could be to set output depending on env vars, github actions sets
CI=true, which could be used as a flag, but this approach gives most flexibility, however the caller must specifiy the output after this.An alternative approach could be to make separate scripts for console logging?