Api: Describe the deployment in CapabilityStatement.implementation - #230
Open
losolio wants to merge 1 commit into
Open
Api: Describe the deployment in CapabilityStatement.implementation#230losolio wants to merge 1 commit into
losolio wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a configurable deployment notice to the FHIR CapabilityStatement returned from /fhir/metadata by wiring a new CapabilityStatementSettings option into the capability statement enrichment path, with supporting documentation and Helm chart values.
Changes:
- Introduces
CapabilityStatementSettingsand injects it intoProfileAwareCapabilityStatementServiceto populateCapabilityStatement.implementation.description. - Registers/binds the new settings in the API startup and DI extension wiring.
- Adds an integration test plus Helm/docs updates for configuration.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Ignis.Api.Tests/FhirControllerTests.cs | Adds coverage asserting the implementation description is present in /fhir/metadata. |
| src/Ignis.Api/Services/Validation/ProfileAwareCapabilityStatementService.cs | Applies configured implementation description onto Spark-generated CapabilityStatement. |
| src/Ignis.Api/Program.cs | Binds CapabilityStatementSettings from configuration. |
| src/Ignis.Api/Extensions/CapabilityStatementExtensions.cs | Passes bound settings into the capability statement service wrapper. |
| src/Ignis.Api/Configuration/CapabilityStatementSettings.cs | Defines the new settings object with a default notice string. |
| infra/helm/charts/app/values.yaml | Adds chart values for capability statement implementation description. |
| infra/helm/charts/app/templates/api-deployment.yaml | Plumbs the chart value into an env var for the API deployment. |
| docs/server/api-configuration.md | Documents the new configuration key and Kubernetes/Helm usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Implementation.description in fhir/metadata now comes from CapabilityStatementSettings. Overridable through with env: CapabilityStatementSettings:ImplementationDescription
losolio
force-pushed
the
feature/capability-description
branch
from
August 1, 2026 21:17
04f08f9 to
47ab391
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation.description in fhir/metadata now comes from CapabilityStatementSettings. Overridable through with env: CapabilityStatementSettings:ImplementationDescription