Skip to content

Log expected deserialization failures at debug level #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennethmyhra merged 2 commits into from
Jul 31, 2026
Merged

Log expected deserialization failures at debug level #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bb5476
Avoid mutating strings during validation
kennethmyhra Jul 31, 2026
1870789
Log expected deserialization failures at debug level
kennethmyhra Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/fhir_models/bootstrap/json.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def self.from_json(json, namespace = FHIR)
klass = namespace.const_get(resource_type)
resource = klass.new(hash)
rescue => ex
FHIR.logger.error("Failed to deserialize JSON:\n#{ex.backtrace}")
FHIR.logger.debug("Failed to deserialize JSON:\n#{ex.backtrace}")
FHIR.logger.debug("JSON:\n#{json}")
resource = nil
end
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir_models/bootstrap/model.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def primitive?(datatype, value)
def check_binding_uri(uri, value)
valid = false
# Strip off the |4.0.0 or |4.0.1 or |2014-03-26 or similar from the ends of URLs
uri&.gsub!(/\|[A-Za-z0-9\.\-]*/, '')
uri = uri&.gsub(/\|[A-Za-z0-9\.\-]*/, '')
valueset = fhir_definitions.get_codes(uri)

if uri == 'http://hl7.org/fhir/ValueSet/mimetypes' || uri == 'http://www.rfc-editor.org/bcp/bcp13.txt'
Expand Down
2 changes: 1 addition & 1 deletion lib/fhir_models/bootstrap/xml.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def self.from_xml(xml, namespace = FHIR)
hash = xml_node_to_hash(doc.root, namespace, klass)
resource = klass.new(hash)
rescue => ex
FHIR.logger.error("Failed to deserialize XML:\n#{ex.backtrace}")
FHIR.logger.debug("Failed to deserialize XML:\n#{ex.backtrace}")
FHIR.logger.debug("XML:\n#{xml}")
resource = nil
end
Expand Down
4 changes: 2 additions & 2 deletions lib/fhir_models/fhirpath/evaluate.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ def self.get(key, hash)
return 'http://unitsofmeasure.org' if key == '%ucum'
return 'http://snomed.info/sct' if key == '%sct'
return 'http://loinc.org' if key == '%loinc'
return key.gsub!(/\A\'|\'\Z/, '') if key.start_with?("'") && key.end_with?("'")
key.gsub!(/\A"|"\Z/, '') # remove quotes around path if they exist
return key.gsub(/\A\'|\'\Z/, '') if key.start_with?("'") && key.end_with?("'")
key = key.gsub(/\A"|"\Z/, '') # remove quotes around path if they exist
if hash.is_a?(Array)
response = []
hash.each do |e|
Expand Down