docs: state both purposes as co-equal, correct the review's premise - #152
Merged
Conversation
The README led with dangling-CNAME detection and listed cloud matching as a bullet, which reads as though the first were the differentiator. It is the other way round: dangling-CNAME tooling is commodity, while identifying A records in claimable cloud space is what this tool adds. The opening now states both jobs, explains why the second is the less obvious one, and says plainly that the tool produces targets and never claims them — which is also why its output files are records rather than reports. REVIEW.md was written against that same misreading. It assessed cloud attribution as a supporting attribute and recorded it as met, at a time when the parser discarded every field that made a match actionable and the output said only "resolved to aws IPs". Rather than quietly rewrite the analysis, the mistaken premise is marked at the point it applies, the affected verdict is withdrawn, and a correction section records what the misframing caused the review to miss and what has since been fixed. Worth stating because it is a sharper version of the lesson already recorded there: that review was internally consistent, evidence-backed and thorough, while measuring against the wrong thing. Rigour applied to a wrong premise produces confident, well-supported, wrong conclusions. The run summary gave cloud matches a quiet line beneath the takeover banner. If the two jobs are co-equal the summary should show it, so cloud-hosted addresses are now announced in their own right, and a run that finds none says so rather than staying silent. Also corrects the wildcard wording. It read "not real hosts", which asserts non-existence that DNS cannot establish — a live site and a fabricated name in the same wildcarded zone return identical answers. It now says resolution proves nothing there, which is what is actually true. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README led with dangling-CNAME detection and listed cloud matching as a bullet, which reads as though the first were the differentiator. It is the other way round: dangling-CNAME tooling is commodity, while identifying A records in claimable cloud space is what this tool adds.
README
The opening now states both jobs as co-equal and explains why the second is the less obvious one:
It also states plainly that the tool produces targets and never claims them, which is why its output files are machine-readable records rather than prose reports.
REVIEW.md
That review was written against the same misreading. It assessed cloud attribution as a supporting attribute and recorded it
✅ Met— at a time when the parser discarded every field that made a match actionable, and the output said onlyresolved to aws IPs.Rather than quietly rewrite the analysis, the mistaken premise is marked where it applies, the affected verdict is withdrawn, and a correction section records what the misframing caused the review to miss:
Both have since been fixed; the correction says so.
It is worth recording because it sharpens a lesson already in that document. The review was internally consistent, evidence-backed and thorough — while measuring against the wrong thing. Rigour applied to a wrong premise produces confident, well-supported, wrong conclusions. Tests being green did not catch it, and neither did the review process itself.
Run summary
Cloud matches sat as a quiet line beneath the takeover banner. If the two jobs are co-equal the summary should show it:
A run that finds none now says so, rather than staying silent — silence reads as "not checked".
Wildcard wording
It read
not real hosts, which asserts non-existence DNS cannot establish: a live site and a fabricated name in the same wildcarded zone return identical answers. It now readsresolution proves nothing, which is what is actually true.257 passed, ruff clean. Documentation and summary text only — no behavioural change to detection or matching.