feat: add 30 takeover fingerprints and lock the pattern set with tests - #147
Merged
Conversation
An unrecognised CNAME target is reported as 'unknown', so a missing fingerprint turns a real takeover candidate into an unactionable line. The set covered 60 services; this adds 30 well-established ones that were absent, cross-referenced against the community project "can-i-take-over-xyz" by EdOverflow. Added: Webflow, Helpjuice, Help Scout, Cargo Collective, UserVoice, Tilda, Big Cartel, Campaign Monitor, Intercom, Thinkific, Canny, Kajabi, Gemfury, Frontify, Aha!, Brightcove, Wishpond, GetResponse, Agile CRM, ReadMe, Hatena Blog, SmugMug, SurveyGizmo, FeedPress, Simplebooklet, Vend, JetBrains YouTrack, Kinsta, Short.io and Pingdom. Each carries a regex, a recommendation naming the action to take, and an evidence link, matching the existing entries. New patterns are appended, so existing fingerprints keep precedence under first-match-wins. Also adds tests for the pattern set itself, which had none. They assert a representative target for each fingerprint classifies to its own category — which catches a broken regex and a pattern shadowed by an earlier one — that an unmatched target is still reported honestly as 'unknown', and that every entry is well formed and compiles. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unrecognised CNAME target is reported as
unknown, so a missing fingerprint turns a genuine takeover candidate into a line nobody can act on. The set covered 60 services; this adds 30 well-established ones that were absent, cross-referenced against the community project "can-i-take-over-xyz" by EdOverflow.Added
Webflow, Helpjuice, Help Scout, Cargo Collective, UserVoice, Tilda, Big Cartel, Campaign Monitor, Intercom, Thinkific, Canny, Kajabi, Gemfury, Frontify, Aha!, Brightcove, Wishpond, GetResponse, Agile CRM, ReadMe, Hatena Blog, SmugMug, SurveyGizmo, FeedPress, Simplebooklet, Vend, JetBrains YouTrack, Kinsta, Short.io and Pingdom.
Each carries a regex, a recommendation naming the action to take, and an evidence link, matching the existing entries. Only fingerprints that are well established were included — nothing speculative.
New patterns are appended, so existing fingerprints keep precedence under first-match-wins.
Tests for the pattern set
The pattern set had no tests of its own, despite being the thing that decides whether a finding is actionable. Added:
unknownrather than being guessed at;Targets are written out explicitly rather than generated from the regexes, so a broken pattern cannot make its own test pass.
243 passed, ruff clean. Existing classifications verified unchanged (Heroku, GitHub Pages, AWS ELB, S3, Azure, Incapsula).
Part of the review roadmap (item PR-F, task F3) — see
ROADMAP.md.