Add pkgdown website - #139
Open
PietrH wants to merge 5 commits into
Open
Conversation
peterdesmet
approved these changes
Apr 8, 2026
peterdesmet
left a comment
peterdesmet
left a comment
Member
There was a problem hiding this comment.
Good to have a website. Did not check output.
See comments for two suggestions for the NEWS.md
| @@ -1,4 +1,5 @@ | |||
| # etnservice (development version) | |||
| - etnservice now has a pkgdown website: [inbo.github.io/etnservice/](https://inbo.github.io/etnservice/). | |||
Member
There was a problem hiding this comment.
I would either:
- Link
pkgdown website - Write the URL as
<https://inbo.github.io/etnservice/>
Also useful to add the PR number at the end in (139) before the closing .
Member
There was a problem hiding this comment.
Curious that usethis places this still in the root, rather than pkgdown/_pkgdown.yml (cf. https://github.com/inbo/etn/tree/main/pkgdown)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a request for swagger documentation for the OpenCPU API. This is not trivial to generate for OpenCPU (unlike plumber).
We can however add a pkgdown website that includes more information on how to adress the etn OpenCPU API. This PR is a first step towards this.
The current function documentation of etnservice is largely still old etn documentation.