Add promotion record predicate type - #532
Conversation
saschagrunert
left a comment
There was a problem hiding this comment.
- docs/new_predicate_guidelines.md require adding the new predicate to spec/predicates/README.md
- The docs/new_predicate_guidelines.md explicitly say 'a field named timestamp is too ambiguous; a better name would be builtAt or allowedAt or scannedAt'. A more descriptive name like promotedAt would follow the guidelines.
| "subject": [{ ... }], | ||
|
|
||
| // Predicate: | ||
| "predicateType": "https://in-toto.io/attestation/promotion-record/v0.1", |
There was a problem hiding this comment.
The spec header says:
Type URI: https://k8s.io/promo-tools/promotion/v1
But the schema example uses: "predicateType": "https://in-toto.io/attestation/promotion-record/v0.1"
One needs to be picked and used consistently. If this is intended to live in the in-toto.io/attestation namespace, use the latter. If it's a Kubernetes-specific namespace, use the former. But then the version also needs to be consistent (v1 vs v0.1).
There was a problem hiding this comment.
OK, I've evened them all to v1. I don't see a need to change this a lot in the foreseeable future. WDYT?
|
I've pushed a last commit that reorganizes the readme and adds this predicate. I also added SVR whcih was missing. |
This adds the promotion precord predicate type. A predicate that records copies of container images between registries. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
05d6ffe to
bdb4a14
Compare
|
I had forgotten to rebase this, @in-toto/attestation-maintainers please take another look. Thanks! |
This adds the Container Image Promotion Record predicate type. A predicate that records copies of container images between registries to ensure automated parties uploaded an image into an OCI registry. As per the spec:
/cc @saschagrunert @cpanato @xmudrii
Signed-off-by: Adolfo García Veytia (Puerco) puerco@carabiner.dev