Repository navigation
T100: the Claude plan backend on Windows - #84
Merged
Merged
Conversation
The claude-cli call gets a minimal environment that held only Unix names, so on Windows Claude Code could not find its login (USERPROFILE, APPDATA) and Node lacked SYSTEMROOT and TEMP: Test connection said only "exited with code 1". Those Windows names are passed now, and a failing call shows the CLI's own JSON "result" (stderr is still never shown).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Windows tester chose Claude plan on Setup. Test connection said only
smoke failed: claude-cli exited with code 1.What
claudecall gets a minimal environment. That list held only Unix names, so on Windows Claude Code could not find its login (USERPROFILE,APPDATA), and Node lackedSYSTEMROOTandTEMP. The list now also passesUSERPROFILE,APPDATA,LOCALAPPDATA,SYSTEMROOT,SYSTEMDRIVE,TEMP,TMP,PATHEXT,COMSPEC,HOMEDRIVE,HOMEPATHandUSERNAME. None of these is a secret.result, up to 200 characters. stderr is still never shown.Checked
CLAUDE_CONFIG_DIRnow says:claude-cli exited with code 1: Not logged in · Please run /login.Not checked