Skip to content

T97: fixes from an outside test run (bare pytest, empty evidence folder, ORIGINALITY facts) - #80

Merged
imthi16 merged 2 commits into
mainfrom
task/T97-grok-findings
Nov 4, 2026
Merged

imthi16 merged 2 commits into
mainfrom
task/T97-grok-findings

Conversation

@imthi16

@imthi16 imthi16 commented Nov 4, 2026

Copy link
Copy Markdown
Owner

Fixes three of the four bugs an outside tester (a Grok agent) found when it ran ProofMerge from a fresh clone with real Meta calls. I checked each one against main before changing anything.

  • Bare pytest -q failed at collection (No module named 'tests'). tests/test_backends.py imports tests.test_meta, and only python -m pytest put the repository on the path. pyproject.toml now sets pythonpath = ["."].
  • An existing empty --evidence-dir was refused with a raw [Errno 17]. verify and probe now use an empty folder. A folder with files, or a file, is still refused, with "Choose a new folder for this run", so old logs never mix into a new run.
  • ORIGINALITY.md was out of date. It named dashboard_static/vendor/ (the folder is dashboard_static/legacy/vendor/) and said the video was not made yet; the README has a 4 min 20 s walkthrough.

Not fixed: a changed test's outcome is recorded per test file, so a test that passes on its own can be listed under a file that failed. The verdict is not affected, but the evidence line is misleading. It comes from how tamper.py runs base tests, so it needs its own change.

Checked

  • Bare pytest -q on this branch: 918 passed, 1 skipped. Before the change, pytest tests/test_backends.py stopped at collection with 1 error; after it, 13 passed.
  • ruff check src tests is clean.
  • A new test covers the folder rule: an empty folder and a new nested one are used; a folder with a file and a file path are refused, and nothing in the refused folder changes.

Not checked

  • A real verify run with an existing empty folder (the folder rule is tested directly and through the existing pipeline tests).
  • The other two failures the tester saw: they needed container networking its machine did not have.

🤖 Generated with Claude Code

…er, ORIGINALITY facts)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T05:35:03.687619Z 1206ccc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@imthi16
imthi16 merged commit 83bdbac into main Nov 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants