Repository navigation
T97: fixes from an outside test run (bare pytest, empty evidence folder, ORIGINALITY facts) - #80
Merged
Merged
Conversation
…er, ORIGINALITY facts) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three of the four bugs an outside tester (a Grok agent) found when it ran ProofMerge from a fresh clone with real Meta calls. I checked each one against
mainbefore changing anything.pytest -qfailed at collection (No module named 'tests').tests/test_backends.pyimportstests.test_meta, and onlypython -m pytestput the repository on the path.pyproject.tomlnow setspythonpath = ["."].--evidence-dirwas refused with a raw[Errno 17].verifyandprobenow use an empty folder. A folder with files, or a file, is still refused, with "Choose a new folder for this run", so old logs never mix into a new run.ORIGINALITY.mdwas out of date. It nameddashboard_static/vendor/(the folder isdashboard_static/legacy/vendor/) and said the video was not made yet; the README has a 4 min 20 s walkthrough.Not fixed: a changed test's outcome is recorded per test file, so a test that passes on its own can be listed under a file that failed. The verdict is not affected, but the evidence line is misleading. It comes from how
tamper.pyruns base tests, so it needs its own change.Checked
pytest -qon this branch: 918 passed, 1 skipped. Before the change,pytest tests/test_backends.pystopped at collection with 1 error; after it, 13 passed.ruff check src testsis clean.Not checked
verifyrun with an existing empty folder (the folder rule is tested directly and through the existing pipeline tests).🤖 Generated with Claude Code