helium/core: add "mute tab" action to tab context menu#1781
Open
saberoueslati wants to merge 6 commits into
Open
helium/core: add "mute tab" action to tab context menu#1781saberoueslati wants to merge 6 commits into
saberoueslati wants to merge 6 commits into
Conversation
|
Reviews (1): Last reviewed commit: "Correct i8n issue" | Re-trigger Greptile |
Comment on lines
+122
to
+127
| <variant name="ToggleMuted" summary="the Toggle muted command"/> | ||
| <variant name="TogglePinned" summary="the Toggle Pinned command"/> | ||
| <variant name="ToggleVertical" summary="the Toggle Vertical tabs command"/> | ||
| + <variant name="ToggleTabAudioMuted" | ||
| + summary="the Toggle Tab Audio Muted command"/> | ||
| </variants> |
There was a problem hiding this comment.
The
ToggleTabAudioMuted variant is placed after ToggleVertical, but alphabetically ToggleTab... should precede ToggleVer.... Chromium histogram tooling often enforces sorted variant lists, and an out-of-order entry can cause PRESUBMIT or lint failures at build time.
Suggested change
| <variant name="ToggleMuted" summary="the Toggle muted command"/> | |
| <variant name="TogglePinned" summary="the Toggle Pinned command"/> | |
| <variant name="ToggleVertical" summary="the Toggle Vertical tabs command"/> | |
| + <variant name="ToggleTabAudioMuted" | |
| + summary="the Toggle Tab Audio Muted command"/> | |
| </variants> | |
| <variant name="ToggleMuted" summary="the Toggle muted command"/> | |
| <variant name="TogglePinned" summary="the Toggle Pinned command"/> | |
| + <variant name="ToggleTabAudioMuted" | |
| + summary="the Toggle Tab Audio Muted command"/> | |
| <variant name="ToggleVertical" summary="the Toggle Vertical tabs command"/> | |
| </variants> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your pull request to not get closed without review, please confirm that:
Tested on (check one or more):
Closes #974
Adds a "Mute tab" / "Unmute tab" toggle to the tab context menu, placed next to the existing "Mute site" item. Operates on the individual tab's audio mute state independently of site-level muting.
CommandToggleTabAudioMutedcommand added toTabStripModelCommandenumWillContextMenuMuteTab()added toTabStripModelto drive the label toggleIDS_TAB_CXMENU_SOUND_MUTE_TAB/IDS_TAB_CXMENU_SOUND_UNMUTE_TABstrings added togenerated_resources.grdtab_menu_model.ccToggleTabAudioMutedhistogram variant added tohistograms.xmlVideo of the manual test on Windows below :
Enregistrement.2026-05-23.142504.mp4
I'll be testing this also on Linux and update the description if it goes fine
Edit :
Works also on Linux, video of the manual testing below :
Screencast.from.2026-05-23.23-24-10.webm