Skip to content

helium/core: add "mute tab" action to tab context menu#1781

Open
saberoueslati wants to merge 6 commits into
imputnet:mainfrom
saberoueslati:feat/mute-tab-context-menu
Open

helium/core: add "mute tab" action to tab context menu#1781
saberoueslati wants to merge 6 commits into
imputnet:mainfrom
saberoueslati:feat/mute-tab-context-menu

Conversation

@saberoueslati

@saberoueslati saberoueslati commented May 23, 2026

Copy link
Copy Markdown

For your pull request to not get closed without review, please confirm that:

  • An issue exists where the maintainers agreed that this should be implemented (an approved feature request, or confirmed bug).
  • I tested that my contribution works locally, and does not break anything, otherwise I have marked my PR as draft.
  • If my contribution is non-trivial, I did not use AI to write most of it.
  • I understand that I will be permanently banned from interacting with this organization if I lied by checking any of these checkboxes.

Tested on (check one or more):

  • Windows
  • macOS
  • Linux

Closes #974

Adds a "Mute tab" / "Unmute tab" toggle to the tab context menu, placed next to the existing "Mute site" item. Operates on the individual tab's audio mute state independently of site-level muting.

  • New CommandToggleTabAudioMuted command added to TabStripModelCommand enum
  • WillContextMenuMuteTab() added to TabStripModel to drive the label toggle
  • IDS_TAB_CXMENU_SOUND_MUTE_TAB / IDS_TAB_CXMENU_SOUND_UNMUTE_TAB strings added to generated_resources.grd
  • Menu item wired through tab_menu_model.cc
  • ToggleTabAudioMuted histogram variant added to histograms.xml

Video of the manual test on Windows below :

Enregistrement.2026-05-23.142504.mp4

I'll be testing this also on Linux and update the description if it goes fine

Edit :

Works also on Linux, video of the manual testing below :

Screencast.from.2026-05-23.23-24-10.webm

@saberoueslati saberoueslati changed the title Feat/mute tab context menu helium/core: add "mute tab" action to tab context menu May 23, 2026
@saberoueslati saberoueslati marked this pull request as ready for review May 23, 2026 22:30
@greptile-apps

greptile-apps Bot commented May 23, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "Correct i8n issue" | Re-trigger Greptile

Comment on lines +122 to +127
<variant name="ToggleMuted" summary="the Toggle muted command"/>
<variant name="TogglePinned" summary="the Toggle Pinned command"/>
<variant name="ToggleVertical" summary="the Toggle Vertical tabs command"/>
+ <variant name="ToggleTabAudioMuted"
+ summary="the Toggle Tab Audio Muted command"/>
</variants>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The ToggleTabAudioMuted variant is placed after ToggleVertical, but alphabetically ToggleTab... should precede ToggleVer.... Chromium histogram tooling often enforces sorted variant lists, and an out-of-order entry can cause PRESUBMIT or lint failures at build time.

Suggested change
<variant name="ToggleMuted" summary="the Toggle muted command"/>
<variant name="TogglePinned" summary="the Toggle Pinned command"/>
<variant name="ToggleVertical" summary="the Toggle Vertical tabs command"/>
+ <variant name="ToggleTabAudioMuted"
+ summary="the Toggle Tab Audio Muted command"/>
</variants>
<variant name="ToggleMuted" summary="the Toggle muted command"/>
<variant name="TogglePinned" summary="the Toggle Pinned command"/>
+ <variant name="ToggleTabAudioMuted"
+ summary="the Toggle Tab Audio Muted command"/>
<variant name="ToggleVertical" summary="the Toggle Vertical tabs command"/>
</variants>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR]: Add a "mute tab" action to tab's context menu

1 participant