ui: improve vertical tab hover expansion and edge polish#1591
Closed
apotenza92 wants to merge 5 commits into
Closed
ui: improve vertical tab hover expansion and edge polish#1591apotenza92 wants to merge 5 commits into
apotenza92 wants to merge 5 commits into
Conversation
|
Reviews (1): Last reviewed commit: "ui/views: polish vertical tab sidebar ed..." | Re-trigger Greptile |
Author
|
Pushed cleanup in 3c2cd87: removed dead hover expand timer/callback, coalesced collapse notifications, removed production _for_testing() usage, and cleaned up the leftover OnPaint override. Ready for re-review. |
Author
|
Pushed e02e015 to fix the malformed patch hunk and regenerate i18n/source.gen.json. Local lint and i18n generation now pass. Could someone please approve the fork workflow runs and re-review when you get a chance? Thanks! |
Author
|
Stable Helium is already addressing most of this except the sidebar opening when moving the mouse faster towards it. I will either make a new PR or just an issue addressing that on macOS specifically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on the hover-expanded vertical tabs direction from #1035. This improves collapsed vertical-tab hover expansion/contraction responsiveness and polishes the sidebar/content edge for hover-expanded states.
Motivation
The main UX issue is that hover expansion should feel responsive and forgiving, closer to Arc/Zen. The follow-up visual issue is that the vertical tab sidebar should have a border line drawn consistently for Zen and non-Zen states with 'rounded frame' turned on or off.
Changes
Hover responsiveness
Sidebar edge polish
VerticalTabStripEdgeBorderViewoverlay strip.GetGenericFrameRadius()for custom sidebar-edge curves.Verification
Tested locally on macOS.
Related
Related to / builds on #1035. That PR established the hover-expanded vertical-tabs direction and this one adds responsiveness plus visual edge polish.