Skip to content

ui: improve vertical tab hover expansion and edge polish#1591

Closed
apotenza92 wants to merge 5 commits into
imputnet:mainfrom
apotenza92:apotenza/vertical-tabs-hover-polish
Closed

ui: improve vertical tab hover expansion and edge polish#1591
apotenza92 wants to merge 5 commits into
imputnet:mainfrom
apotenza92:apotenza/vertical-tabs-hover-polish

Conversation

@apotenza92

@apotenza92 apotenza92 commented May 5, 2026

Copy link
Copy Markdown

Summary

Builds on the hover-expanded vertical tabs direction from #1035. This improves collapsed vertical-tab hover expansion/contraction responsiveness and polishes the sidebar/content edge for hover-expanded states.

Motivation

The main UX issue is that hover expansion should feel responsive and forgiving, closer to Arc/Zen. The follow-up visual issue is that the vertical tab sidebar should have a border line drawn consistently for Zen and non-Zen states with 'rounded frame' turned on or off.

Changes

Hover responsiveness

  • Makes collapsed vertical tabs expand more consistently on hover with overshoot regions outside of the visible browser window and also allowance for much faster cursor movement to the edge of the window.
  • Keeps contraction predictable on mouse exit.
  • Makes Zen and non-Zen expansion on hover consistent in animation and speed.

Sidebar edge polish

  • Adds a BrowserView-level transparent VerticalTabStripEdgeBorderView overlay strip.
  • Lets rounded edge strokes paint outside the sidebar bounds without adding a layout gap.
  • Uses GetGenericFrameRadius() for custom sidebar-edge curves.
  • Masks overlong underlying content-outline strokes where rounded-frame is enabled.
  • Keeps rounded top sidebar/content corner for non-Zen hover-expanded mode even when rounded-frame is disabled.

Verification

Tested locally on macOS.

Related

Related to / builds on #1035. That PR established the hover-expanded vertical-tabs direction and this one adds responsiveness plus visual edge polish.

@apotenza92 apotenza92 marked this pull request as ready for review May 5, 2026 11:12
@greptile-apps

greptile-apps Bot commented May 5, 2026

Copy link
Copy Markdown

Reviews (1): Last reviewed commit: "ui/views: polish vertical tab sidebar ed..." | Re-trigger Greptile

Comment thread patches/helium/ui/layout/vertical-hover-responsive.patch
Comment thread patches/helium/ui/layout/vertical-hover-responsive.patch
Comment thread patches/helium/ui/layout/vertical-hover-edge-border-overlay.patch
@apotenza92

Copy link
Copy Markdown
Author

Pushed cleanup in 3c2cd87: removed dead hover expand timer/callback, coalesced collapse notifications, removed production _for_testing() usage, and cleaned up the leftover OnPaint override. Ready for re-review.

@apotenza92

Copy link
Copy Markdown
Author

Pushed e02e015 to fix the malformed patch hunk and regenerate i18n/source.gen.json. Local lint and i18n generation now pass.

Could someone please approve the fork workflow runs and re-review when you get a chance?

Thanks!

@apotenza92

Copy link
Copy Markdown
Author

Stable Helium is already addressing most of this except the sidebar opening when moving the mouse faster towards it. I will either make a new PR or just an issue addressing that on macOS specifically.

@apotenza92 apotenza92 closed this May 29, 2026
@apotenza92 apotenza92 deleted the apotenza/vertical-tabs-hover-polish branch May 29, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant