-
-
Notifications
You must be signed in to change notification settings - Fork 45
helium/linux: middle-click on empty tab strip opens new tab #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
saberoueslati
wants to merge
2
commits into
imputnet:main
Choose a base branch
from
saberoueslati:helium/linux/middle-click-tab-strip-opens-new-tab
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
81 changes: 81 additions & 0 deletions
81
patches/helium/linux/middle-click-empty-tabstrip-opens-new-tab.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| --- a/chrome/browser/ui/views/tabs/tab_strip.h | ||
| +++ b/chrome/browser/ui/views/tabs/tab_strip.h | ||
| @@ -401,6 +401,8 @@ class TabStrip : public views::View, | ||
| // views::View: | ||
| void OnMouseEntered(const ui::MouseEvent& event) override; | ||
| void OnMouseExited(const ui::MouseEvent& event) override; | ||
| + bool OnMousePressed(const ui::MouseEvent& event) override; | ||
| + void OnMouseReleased(const ui::MouseEvent& event) override; | ||
| void AddedToWidget() override; | ||
| void RemovedFromWidget() override; | ||
| void OnThemeChanged() override; | ||
| --- a/chrome/browser/ui/views/tabs/tab_strip.cc | ||
| +++ b/chrome/browser/ui/views/tabs/tab_strip.cc | ||
| @@ -2443,6 +2443,21 @@ void TabStrip::OnMouseExited(const ui::MouseEvent& event) { | ||
| UpdateHoverCard(nullptr, HoverCardUpdateType::kHover); | ||
| } | ||
|
|
||
| +bool TabStrip::OnMousePressed(const ui::MouseEvent& event) { | ||
| + if (event.IsOnlyMiddleMouseButton() && !GetTabAt(event.location())) { | ||
| + return true; | ||
| + } | ||
| + return views::View::OnMousePressed(event); | ||
| +} | ||
| + | ||
| +void TabStrip::OnMouseReleased(const ui::MouseEvent& event) { | ||
| + if (event.IsOnlyMiddleMouseButton() && !GetTabAt(event.location())) { | ||
| + controller_->CreateNewTab(NewTabTypes::kNewTabButton); | ||
| + return; | ||
| + } | ||
| + views::View::OnMouseReleased(event); | ||
| +} | ||
| + | ||
| void TabStrip::AddedToWidget() { | ||
| GetWidget()->AddObserver(this); | ||
| paint_as_active_subscription_ = | ||
| --- a/chrome/browser/ui/views/frame/horizontal_tab_strip_region_view.cc | ||
| +++ b/chrome/browser/ui/views/frame/horizontal_tab_strip_region_view.cc | ||
| @@ -26,6 +26,7 @@ | ||
| #include "chrome/browser/ui/tabs/tab_menu_model.h" | ||
| #include "chrome/browser/ui/tabs/tab_strip_model.h" | ||
| #include "chrome/browser/ui/tabs/tab_strip_prefs.h" | ||
| +#include "chrome/browser/ui/tabs/tab_enums.h" | ||
| #include "chrome/browser/ui/ui_features.h" | ||
| #include "chrome/browser/ui/views/chrome_layout_provider.h" | ||
| #include "chrome/browser/ui/views/frame/browser_view.h" | ||
| @@ -106,6 +107,21 @@ class FrameGrabHandle : public views::View { | ||
| return gfx::Size(27, 0); | ||
| } | ||
|
|
||
| + bool OnMousePressed(const ui::MouseEvent& event) override { | ||
| + if (event.IsOnlyMiddleMouseButton()) { | ||
| + return true; | ||
| + } | ||
| + return views::View::OnMousePressed(event); | ||
| + } | ||
| + | ||
| + void OnMouseReleased(const ui::MouseEvent& event) override { | ||
| + if (event.IsOnlyMiddleMouseButton() && tab_strip_) { | ||
| + tab_strip_->controller()->CreateNewTab(NewTabTypes::kNewTabButton); | ||
| + return; | ||
| + } | ||
| + views::View::OnMouseReleased(event); | ||
| + } | ||
| + | ||
| private: | ||
| base::WeakPtr<TabStrip> tab_strip_; | ||
| }; | ||
| --- a/ui/views/widget/desktop_aura/window_event_filter_linux.cc | ||
| +++ b/ui/views/widget/desktop_aura/window_event_filter_linux.cc | ||
| @@ -118,9 +118,9 @@ void WindowEventFilterLinux::OnClickedCaption(ui::MouseEvent* event, | ||
| if (event->changed_button_flags() & ui::EF_RIGHT_MOUSE_BUTTON) { | ||
| action_type = ui::LinuxUi::WindowFrameActionSource::kRightClick; | ||
| default_action = ui::LinuxUi::WindowFrameAction::kMenu; | ||
| } else if (event->changed_button_flags() & ui::EF_MIDDLE_MOUSE_BUTTON) { | ||
| - action_type = ui::LinuxUi::WindowFrameActionSource::kMiddleClick; | ||
| - default_action = ui::LinuxUi::WindowFrameAction::kNone; | ||
| + // Let the views hierarchy handle middle click (e.g. tab strip opens new tab). | ||
| + return; | ||
| } else if (event->changed_button_flags() & ui::EF_LEFT_MOUSE_BUTTON && | ||
| event->flags() & ui::EF_IS_DOUBLE_CLICK) { | ||
| click_component_ = HTNOWHERE; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The early
returninOnClickedCaptionskips callingGetWindowFrameAction(kMiddleClick, ...)globally, not just for the tab strip. Users who have configured a desktop environment action for middle-clicking the title bar (e.g. lower window, minimize) will silently lose that behaviour even when clicking on window chrome outside the tab strip. The previous code already defaulted tokNone, so most users are unaffected, but this is a broader behavioral change than the PR description implies. It would be worth a comment in the code noting that DE middle-click-caption actions are intentionally suppressed browser-wide.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they will lose that behavior indeed, and it is intentional, I'll add the comment if the reviewer wants me to