Repository navigation
fix(ci): approve branding assets and keep privacy scan exit code clean - #4
Merged
Merged
Conversation
The branding commit added docs/assets/impossible-voice-scene.gif and social-preview.png without approving their hashes, so the privacy scan rejected them. The scan also ended with the exit code of an unset 'git config --get user.name' on CI, failing the step after a passing scan. Approve both assets by hash and exit 0 explicitly on success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by mau
Before: CI on
mainhad never passed. The privacy scan rejecteddocs/assets/impossible-voice-scene.gifanddocs/assets/social-preview.pngas "unexpected binary content", because the branding commit added them without approving their hashes. Even when the scan found nothing, the step still failed: the script ended with the exit code ofgit config --get user.name, which is 1 on CI runners where no user name is set.After: both branding assets are approved by SHA-256, as the header image already was, and the script exits 0 explicitly after a passing scan. Any other binary file, or a changed asset, still fails the scan.
How: two entries were added to
$approvedBinaryHashes, and anexit 0follows the success message. This PR unblocks CI for #1, #2 and #3.