fix: holder DID must match the signing key for vc+sd-jwt - #760
Open
coplat wants to merge 5 commits into
Open
Conversation
nanderstabel
previously approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
When presenting a
vc+sd-jwtcredential over OID4VP, the VP jwt'sholderandisshad a different DID than the key that signed it, so UniCore+'s verification flow failed with the error:"Invalid OID4VP Authorization Response: Presentation validation error: [the holder's id does not match the provided DID Document(s)]".
get_vp_tokenderivedholder/issfrom the algorithm negotiated with the verifier (EdDSA by default), but theFormat::VcSdJwtarm signs with the credential'scnfkey (ES256 here).The fix derives
holderandissfromcnf_kidinside the VcSdJwt arm.Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #.How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.