Skip to content

fix: holder DID must match the signing key for vc+sd-jwt - #760

Open
coplat wants to merge 5 commits into
feat/connection-pagefrom
fix/invalid-holder-did
Open

fix: holder DID must match the signing key for vc+sd-jwt#760
coplat wants to merge 5 commits into
feat/connection-pagefrom
fix/invalid-holder-did

Conversation

@coplat

@coplat coplat commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Description of change

When presenting a vc+sd-jwt credential over OID4VP, the VP jwt's holder and iss had a different DID than the key that signed it, so UniCore+'s verification flow failed with the error:

"Invalid OID4VP Authorization Response: Presentation validation error: [the holder's id does not match the provided DID Document(s)]".

get_vp_token derived holder/iss from the algorithm negotiated with the verifier (EdDSA by default), but the Format::VcSdJwt arm signs with the credential's cnf key (ES256 here).

The fix derives holder and iss from cnf_kid inside the VcSdJwt arm.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@coplat coplat self-assigned this Aug 27, 2026
@coplat coplat added the Bug Something isn't working label Aug 27, 2026
@coplat
coplat marked this pull request as ready for review August 27, 2026 15:40
nanderstabel
nanderstabel previously approved these changes Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants