Mappers requests#763
Merged
Merged
Conversation
github-actions
Bot
added
size/Small
Change Wiz Code
dantanat1
requested changes
Jul 21, 2026
| private void OnInit(Entity<SkillsComponent> entity, ref MapInitEvent args) | ||
| { | ||
| if (entity.Comp.Levels["Intelligence"] >= 12) | ||
| AddComp<MagicRuneKnowledgeComponent>(entity); |
Contributor
There was a problem hiding this comment.
Изменить AddComp на EnsureComp, может вызвать ошибку если у мага УЖЕ есть этот компонент
Zakvielian
marked this pull request as draft
July 21, 2026 22:01
Zakvielian
marked this pull request as ready for review
July 22, 2026 17:06
github-actions
Bot
added
size/Small
Resprite
dantanat1
reviewed
Jul 22, 2026
| .suffix = { "Средневековье" } | ||
| ent-MedievalLockpickPack = набор отмычек | ||
| .desc = Базовый шанс поломки: низкий. Скорость взлома: высокая. Стрелка вверх(оранжевый) - искомое значение больше, вниз(синий) - меньше. | ||
| .desc = Базовый шанс поломки: низкий. Скорость взлома: высокая. Стрелка вверх - искомое значение больше, вниз - меньше. Оранжевый - значение близко, синий - далеко. |
Contributor
There was a problem hiding this comment.
Добавить подсказку о том, что подсказки вверх/вниз даются только при наличии соответствующего трейта
Contributor
Author
|
Исправил |
dantanat1
requested changes
Jul 22, 2026
| invisible-floor-space = Мелководье | ||
| MedievalWoodenFloorRoofItem = большой деревянный пол (с крышей) | ||
| ent-MedievalWoodenFloorRoofItem = заготовка деревянного пола (с крышей) |
Contributor
There was a problem hiding this comment.
Необходимо добавить суффикс.
| if (!TryComp<SkillsComponent>(uid, out var comp)) | ||
| return; | ||
|
|
||
| if (comp.Levels["Intelligence"] >= 10) |
Contributor
There was a problem hiding this comment.
Значение должно быть 15. Почему ты опять его изменил?
Contributor
Author
There was a problem hiding this comment.
Извини, я поставил для теста 10, а потом забыл исправить
Zakvielian
commented
Jul 23, 2026
Zakvielian
left a comment
Zakvielian
left a comment
Contributor
Author
There was a problem hiding this comment.
Исправления внесены
| if (!TryComp<SkillsComponent>(uid, out var comp)) | ||
| return; | ||
|
|
||
| if (comp.Levels["Intelligence"] >= 10) |
Contributor
Author
There was a problem hiding this comment.
Извини, я поставил для теста 10, а потом забыл исправить
Contributor
Author
There was a problem hiding this comment.
В идеале для мешковины разбойника убрать броню, либо наследование у неё изменить
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
О ПР`е
Тип: fix, feat
Изменения: На используемых на картах плитках всегда идет погода. Добавлен MagicRuneKnownladge от 15 инты, пофикшино пару причин вылетов в дебаге, добавлен туман, добавлен знак алхимика
Технические детали
Нет
Изменения кода официальных разработчиков
Нет