fix: use book diff px as the resting price for new orders#5
Open
felix5572 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR A(resting px):
Also: official repo PR#9
▎ The resting price of a new order is taken from the order status, but trigger/converted orders can carry a different px on the status than the price they actually rest at. The book diff's px is the true resting price. Using the status px leaves wrong prices on the book and makes subsequent diffs unmatchable. This PR stores the diff px
▎ in pending_new_diffs (diff-first arrival) and applies it on pairing (status-first arrival), failing fast on an unparseable px instead of silently keeping the status px. Covers both arrival orders with tests.