Simplified number implentation#15
Open
logicplace wants to merge 14 commits into
Open
Conversation
* Filled in stubs in KeyMap * Allow ! anywhere in special refs, to access relatives' special refs * Remove the concept of freezing (for now at least), too complex and seemed redundant * deepcopy needs to update KeyMap owners (this could be handled better?) * some naming changes - normalize -> imperialize because they return different types - set_key -> set_by_key because it's clearer English
* converters moved from Value to ImperialType * parents/containers methods moved from Dynamic to ImperialType * missing imports added, some copypaste issues, misc style, autoformatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1
Implements a bare-bones Number class which will be fundamental for other things moving forward, and eventually expanded in #8
This adds some basic unit tests for the new classes. It should probably have more, but I can't really think of any. Open to suggestions (or PRs onto this branch).
Please review Number and BaseNumber thinking about how easy it looks to implement a new struct. For the other ones, don't think about that at all, because they're core stuff and very specific... Some readability is still expected, but this project is taking a "shove all the ugly stuff in the core" approach, to make library development easier to approach.