Skip to content

chore: immich_mobile path in openapi pubspec - #30643

Merged
shenlong-tanwen merged 1 commit into
mainfrom
chore/pubspec-path
Aug 12, 2026
Merged

chore: immich_mobile path in openapi pubspec#30643
shenlong-tanwen merged 1 commit into
mainfrom
chore/pubspec-path

Conversation

@shenlong-tanwen

Copy link
Copy Markdown
Member

No description provided.

@alextran1502

Copy link
Copy Markdown
Member

Why do we need to change this?

@shenlong-tanwen

Copy link
Copy Markdown
Member Author

Why do we need to change this?

The autogen code is now under the generated directory. So every time we run mise codegen an error was emitted as the openapi library couldn't resolve the main app's path

@agg23

agg23 commented Aug 10, 2026

Copy link
Copy Markdown
Member

What error is this solving? I thought it was

[//:open-api-dart] [main] INFO  o.o.c.ignore.CodegenIgnoreProcessor - Output directory (/Users/adam/code/immich/open-api/../mobile/generated/openapi) does not exist, or is inaccessible. No file (.openapi-generator-ignore) will be evaluated.

But that still occurs with this fix.

@shenlong-tanwen

shenlong-tanwen commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

What error is this solving?

The open-api package has a dependency on the root package but the path on the pubspec was incorrect. So everytime I did mise codegen, analyzer inside VSCode was crying because of it. This changes the path to point to the actual path of the root library pubspec. The app was building irrespective of the wrong path as we resolve the dependencies from the root package so the wrong path here was irrelevant to it. This is more of a correctness change

Edit: Also, the change I made initially was incorrect for this, I've force pushed now with the proper path

@shenlong-tanwen
shenlong-tanwen merged commit ff5da0f into main Aug 12, 2026
54 of 55 checks passed
@shenlong-tanwen
shenlong-tanwen deleted the chore/pubspec-path branch August 12, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants