You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The autogen code is now under the generated directory. So every time we run mise codegen an error was emitted as the openapi library couldn't resolve the main app's path
[//:open-api-dart] [main] INFO o.o.c.ignore.CodegenIgnoreProcessor - Output directory (/Users/adam/code/immich/open-api/../mobile/generated/openapi) does not exist, or is inaccessible. No file (.openapi-generator-ignore) will be evaluated.
The open-api package has a dependency on the root package but the path on the pubspec was incorrect. So everytime I did mise codegen, analyzer inside VSCode was crying because of it. This changes the path to point to the actual path of the root library pubspec. The app was building irrespective of the wrong path as we resolve the dependencies from the root package so the wrong path here was irrelevant to it. This is more of a correctness change
Edit: Also, the change I made initially was incorrect for this, I've force pushed now with the proper path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.