feat(web): new search ui - #30279
Conversation
|
Deploying preview environment to https://pr-30279.preview.internal.immich.build/ |
jrasm91
left a comment
jrasm91
left a comment
There was a problem hiding this comment.
There is a lot of shared state for search. I am wondering if it would be better/easier if all the related state was pulled out into a global manager, like const searchManager new SearchManager() and then components just used methods on the search manager to manipulate state.
Some methods that might make sense would be like:
class SearchManager {
get filters()
submit()
reset()
addFilter(key, value)
clearFilter(key)
..
|
Code and functionality both look good! I noticed a few issues when clearing a search filter and then opening the search box and seeing the old state still.
|
danieldietzler
left a comment
danieldietzler
left a comment
There was a problem hiding this comment.
Could get the code cleaned up a bit, but overall this looks really good and already is an improvement over what we currently have!
| const start = after?.toMillis(); | ||
| const end = before?.endOf('day').toMillis(); | ||
|
|
||
| if (start === +DateTime.utc().startOf('year') && end === +DateTime.utc().endOf('year')) { |
There was a problem hiding this comment.
Shorthand for milliseconds
| } | ||
|
|
||
| let { selectedPeople = $bindable() }: Props = $props(); | ||
| // eslint-disable-next-line no-useless-assignment |
There was a problem hiding this comment.
Why exactly did this throw? It shouldn't
There was a problem hiding this comment.
title is never read in the file so the assignments are useless to the linter
4 participants
Implementation of the new search UI on the web, not yet pixel perfect with the design doc since a few overall style changes need to be made in immich UI.
