refactor!: disallow star rating < 1 - #27896
Conversation
7c01bd4 to
2325a35
Compare
|
Currently this breaks the mobile implementation of star rating. |
| description: z.string().nullish().default(null).describe('Image description'), | ||
| projectionType: z.string().nullish().default(null).describe('Projection type'), | ||
| rating: z.number().nullish().default(null).describe('Rating'), | ||
| rating: z.int().min(1).max(5).nullish().default(null).describe('Rating'), |
There was a problem hiding this comment.
As a response dto this should be fine, it only describes the range the server can return.
1424b08 to
f16a83f
Compare
|
What's the plan with this? Aren't we waiting for open API to release the PR? |
|
I don't know, there has not been any activity on Timon's PR and this one is ready, we could later update the valid range from |
#27231 is blocked by an open PR in upstream in the generator. we can go ahead with this PR meanwhile (although would mean another breaking change technically when updating the range from 0 to 1 as min) EDIT: i'd not merge this yet, since it does not add real value before lifting the lower boundary to 1 finally |
|
@meesfrensel #27231 has been merged, so this PR is unblocked now. We should now be able to constrain on |
f7dbdbb to
7d23160
Compare
|
📱 Android release APK (universal) — Download: https://github.com/immich-app/immich/actions/runs/26966539494/artifacts/7417931103 QR codeInstalls as a separate app (applicationId |
|
@shenlong-tanwen @danieldietzler I migrated the mobile call-sites now. As discussed we keep using and as Mees pointed out, the migration files needs a rename |
5 participants
Description
The breaking change counterpart to #26357
Including migrating to convert -1 to null in the DB.
Caution
Breaking Change
Accepted ratings for assets are changed from
[-1, 5] | nullto[1, 5] | null.includes the mobile side migration (asset rating and search)
Please describe to which degree, if any, an LLM was used in creating this pull request.
None