Skip to content

fix(ait): fail closed on missing ad support constants#104

Merged
imjlk merged 1 commit into
mainfrom
codex/ait-host-capability-support
Jul 20, 2026
Merged

fix(ait): fail closed on missing ad support constants#104
imjlk merged 1 commit into
mainfrom
codex/ait-host-capability-support

Conversation

@imjlk

@imjlk imjlk commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • treat missing Apps in Toss Ads 2.0 support constants as unsupported
  • preserve fail-closed preload and display behavior without blocking wrapper startup
  • retain debug diagnostics for unexpected native support-check failures

Validation

  • adapter tests: 46 passed
  • adapter type check passed
  • repository check passed
  • open-code-review: no comments

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@imjlk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 56ca79f3-a031-465c-8b19-c13f887188b7

📥 Commits

Reviewing files that changed from the base of the PR and between e0b0598 and 7dd281e.

📒 Files selected for processing (3)
  • .sampo/changesets/ait-host-capability-support.md
  • adapters/ait/src/host.test.ts
  • adapters/ait/src/host.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/ait-host-capability-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@imjlk
imjlk merged commit dd7513b into main Jul 20, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7dd281e666

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread adapters/ait/src/host.ts
}

if (!dependencies.loadFullScreenAd.isSupported()) {
if (!isCapabilitySupported(() => dependencies.loadFullScreenAd.isSupported())) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate preloads on both full-screen ad APIs

When loadFullScreenAd.isSupported() returns true but showFullScreenAd.isSupported() is missing or false, this branch still calls loadFullScreenAd and reports preload success even though runtime.getCapabilities and the show calls fail closed via areFullScreenAdsSupported. In that partial-support compatibility case, preloading can invoke the native Ads 2.0 load path on a host that cannot display the ad; use the same combined support check here so configured preloads are also fail-closed until both APIs report support.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant